Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added EPB and Brake_Hold #61

Merged
merged 2 commits into from
Dec 21, 2017
Merged

Added EPB and Brake_Hold #61

merged 2 commits into from
Dec 21, 2017

Conversation

joeljacobs
Copy link
Contributor

Searched through Cabana with @energee to find proper signals for EPB and Brake_Hold. We found them. 

@@ -111,6 +114,11 @@ BO_ 432 STANDSTILL: 7 VSA
SG_ CHECKSUM : 51|4@0+ (1,0) [0|3] "" EON

BO_ 450 XXX_6: 8 XXX
SG_ EPB_Brake_and_Pull_Indicator : 6|1@0+ (1,0) [0|1] "" XXX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeljacobs can you use CAPITAL notation here too? other than that it looks good

@rbiasini rbiasini merged commit 0d3aea0 into commaai:master Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants