Skip to content

Commit

Permalink
Honda Civic & CR-V Bosch: allow fingerprinting without comma power (#…
Browse files Browse the repository at this point in the history
…31259)

* Honda Civic Bosch: remove OBD-reliant ECUs from fingerprinting

* eligible to fingerprint with these responses now

* same for CRV bosch

* add back all FW to test fingerprinting diff on data

* set these ECUs as non essential instead

* comment

* compare old fingerprinting with non essential fingerprinting

* clean up

* cmt
  • Loading branch information
sshane authored Feb 10, 2024
1 parent f873224 commit e02ec88
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion selfdrive/car/honda/values.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,19 @@ def init_make(self, CP: car.CarParams):
[StdQueries.UDS_VERSION_REQUEST],
[StdQueries.UDS_VERSION_RESPONSE],
bus=1,
logging=True,
obd_multiplexing=False,
),
],
# We lose these ECUs without the comma power on these cars.
# Note that we still attempt to match with them when they are present
non_essential_ecus={
Ecu.programmedFuelInjection: [CAR.CIVIC_BOSCH, CAR.CRV_5G],
Ecu.transmission: [CAR.CIVIC_BOSCH, CAR.CRV_5G],
Ecu.vsa: [CAR.CIVIC_BOSCH, CAR.CRV_5G],
Ecu.combinationMeter: [CAR.CIVIC_BOSCH, CAR.CRV_5G],
Ecu.gateway: [CAR.CIVIC_BOSCH, CAR.CRV_5G],
Ecu.electricBrakeBooster: [CAR.CIVIC_BOSCH, CAR.CRV_5G],
},
extra_ecus=[
# The only other ECU on PT bus accessible by camera on radarless Civic
(Ecu.unknown, 0x18DAB3F1, None),
Expand Down

0 comments on commit e02ec88

Please sign in to comment.