Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honda Civic & CR-V Bosch: allow fingerprinting without comma power #31259

Merged
merged 12 commits into from
Feb 10, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Feb 1, 2024

#31244 hasn't plugged in their comma power. I checked a few VINs with different first character prefixes (different regions) and they all return fwdRadar, fwdCamera, eps, srs on bus 1, non-OBD multiplexed

Civic Bosch checked:

  • f1109d8294ea80ac|2024-01-30--10-44-56
  • f5392228324cda8d|2024-01-13--17-01-57
  • dd8aedf56faa8661|2024-01-31--18-02-17
  • f99ab12043ad3219|2024-01-29--14-04-34
  • fa1dc48cb5a31191|2024-01-31--14-37-42

CR-V Bosch checked:

  • ffa76986ec8e871e|2024-01-31--07-53-40
  • fd114cff219d3bb8|2024-01-05--06-24-31

@sshane sshane changed the title Honda Civic Bosch: remove OBD-reliant ECUs Honda Civic & CR-V Bosch: remove OBD-reliant ECUs Feb 1, 2024
@sshane
Copy link
Contributor Author

sshane commented Feb 9, 2024

Checking mock routes last 90 days: Checked routes: 7287, dongles: 311 platforms: {'mock': 7287}

Found 16 dongles that had mock routes that now fingerprint to one of these platforms! They likely didn't have the comma power plugged in at the time.

{'ffa76986ec8e871e', '54f2cff3e445c51e', 'a3367c53243b7b6a', '0b718b64b3db2644', '73cb0f6b2f2b4a80', '8faf799674fa044b', '90d56ac785678835', 'd33bc6acf39eb0d5', 'c9ff14d9c5fffff5', 'dd5d48ede2163c1f', 'addf4f63ee4758f3', '54a9cb1cf2339a4d', '10917e25a617d160', '2081adf2f16f26ae', '0a25f64738efe521', '008d92ddb9798681'}

@sshane
Copy link
Contributor Author

sshane commented Feb 10, 2024

The lost ECUs could have a substantial amount of info relevant for fuzzy FP in the future, leaving them in database for now in case it helps.

Instead we will add the cars/ECUs to the non_essential_ecus dict in the config which won't change fingerprinting behavior for comma power cars. Despite the fact I found only one case where a dongle failed to fingerprint after this change due to missing versions (not ECUs), it could still impact fingerprinting for future users, so going to take this approach first. We can always remove the FWs in the future when the majority of users aren't using a power and there's no point in keeping them.

@sshane sshane changed the title Honda Civic & CR-V Bosch: remove OBD-reliant ECUs Honda Civic & CR-V Bosch: allow fingerprinting without comma power Feb 10, 2024
@sshane sshane merged commit e02ec88 into master Feb 10, 2024
30 checks passed
@sshane sshane deleted the civic-bosch-no-obd branch February 10, 2024 01:23
@adeebshihadeh
Copy link
Contributor

Why only for two cars? Do we expect this to scale to other models?

@sshane
Copy link
Contributor Author

sshane commented Feb 10, 2024

Yes, I just did the verification for the user's car in that issue to look out for issues on a smaller sample. Next is to verify each model (not sure if we get different ECUs per architecture, platform, or even by MY yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants