-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honda Accord: allow fingerprinting without comma power #31477
Conversation
Expanded the verification to 2 years. There's some issues with old routes, since we used to gather the CAN fingerprint with only the OBD port connected before #27656, so we'll need to ignore those. |
Ran test_models on this data with the detection before combining any platforms, and it raised no assertions that the detection mismatched the hard-coding except 5 segments below: # Comma remote last 720 days >= 0.9.3/-release
# Checked routes: 210779, dongles: 614, platform segments:
{'HONDA ACCORD HYBRID 2018': 15742, 'HONDA CR-V 2017': 28775, 'HONDA CIVIC 2022': 4274, 'HONDA ACCORD 2018': 27972, 'HONDA PILOT 2017': 24741, 'HONDA CIVIC (BOSCH) 2019': 15105, 'HONDA ODYSSEY 2018': 33816, 'HONDA HR-V 2023': 316, 'HONDA CIVIC 2016': 13046, 'ACURA RDX 2020': 5459, 'HONDA FREED 2020': 817, 'HONDA RIDGELINE 2017': 27037, 'HONDA INSIGHT 2019': 5606, 'HONDA HRV 2019': 2286, 'HONDA CR-V HYBRID 2019': 1202, 'ACURA RDX 2018': 1264, 'HONDA FIT 2018': 2643, 'HONDA CR-V 2016': 602, 'ACURA ILX 2016': 71, 'HONDA ODYSSEY CHN 2019': 5} MismatchesThe only cases were when the detection didn't see the BRAKE_MODULE message, but the platform was in the set.
|
Checked last year of data on comma remote: No cases where radar or camera were missing on the PT bus since we started logging The other case was a route in park for 1 minute with camera and radar missing |
Running final test now: 21bf0bb Looks good, no failures! |
it works! 440a155809ba2b6d/2024-02-27--20-06-38 |
Continuing from #31259
The entire FW versions aren't shared with any other platform except the Honda Accord Hybrid. So we will need to combine these platforms before we can do this.
HONDA_BOSCH_ALT_BRAKE_SIGNAL
TransmissionType.cvt