Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honda Accord: allow fingerprinting without comma power #31477

Merged
merged 41 commits into from
Feb 28, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Feb 15, 2024

Continuing from #31259

The entire FW versions aren't shared with any other platform except the Honda Accord Hybrid. So we will need to combine these platforms before we can do this.

  • Combine Accord & Accord Hybrid
  • Detect HONDA_BOSCH_ALT_BRAKE_SIGNAL
    • Verify
  • Detect TransmissionType.cvt
  • Test to make sure we can fingerprint uniquely without non_essential_ecus

@github-actions github-actions bot added car vehicle-specific honda labels Feb 15, 2024
@sshane
Copy link
Contributor Author

sshane commented Feb 17, 2024

Expanded the verification to 2 years. There's some issues with old routes, since we used to gather the CAN fingerprint with only the OBD port connected before #27656, so we'll need to ignore those.

image

@sshane
Copy link
Contributor Author

sshane commented Feb 17, 2024

Ran test_models on this data with the detection before combining any platforms, and it raised no assertions that the detection mismatched the hard-coding except 5 segments below:

# Comma remote last 720 days >= 0.9.3/-release
# Checked routes: 210779, dongles: 614, platform segments:

{'HONDA ACCORD HYBRID 2018': 15742, 'HONDA CR-V 2017': 28775, 'HONDA CIVIC 2022': 4274, 'HONDA ACCORD 2018': 27972, 'HONDA PILOT 2017': 24741, 'HONDA CIVIC (BOSCH) 2019': 15105, 'HONDA ODYSSEY 2018': 33816, 'HONDA HR-V 2023': 316, 'HONDA CIVIC 2016': 13046, 'ACURA RDX 2020': 5459, 'HONDA FREED 2020': 817, 'HONDA RIDGELINE 2017': 27037, 'HONDA INSIGHT 2019': 5606, 'HONDA HRV 2019': 2286, 'HONDA CR-V HYBRID 2019': 1202, 'ACURA RDX 2018': 1264, 'HONDA FIT 2018': 2643, 'HONDA CR-V 2016': 602, 'ACURA ILX 2016': 71, 'HONDA ODYSSEY CHN 2019': 5}

Mismatches

The only cases were when the detection didn't see the BRAKE_MODULE message, but the platform was in the set.

expected mismatch segment notes
HONDA CR-V 2017 3fa19dc26a914d9d/2023-11-04--19-18-20--32 route goes CAN invalid and most traffic drops off
HONDA CR-V 2017 3fa19dc26a914d9d/2023-11-04--19-18-20--35 same
HONDA CR-V 2017 3fa19dc26a914d9d/2023-11-04--19-18-20--38 same
HONDA HR-V 2023 495ad4581a73fe31/2023-10-25--20-14-20--2 user in Taiwan hard-coding to this car with no FW + removed the car from the alt brake signal set. According to #27915, global Hondas may not require this message, so this is expected. This is actually the car in PR: #30337
HONDA CR-V 2017 503aca742a84e30b/2023-11-11--17-28-02--16 same type of CAN error and message drop off

@sshane sshane marked this pull request as draft February 17, 2024 12:41
@sshane
Copy link
Contributor Author

sshane commented Feb 28, 2024

Checked last year of data on comma remote: Checked routes: 40110, dongles: 182 platforms: 2

No cases where radar or camera were missing on the PT bus since we started logging obdMultiplexing, except for dd06cc12fb60baf3|2023-10-02--18-43-29 and dd06cc12fb60baf3|2023-10-05--06-48-12. Unfortunately there's no rlogs for these routes. Later routes have the ECUs.

The other case was a route in park for 1 minute with camera and radar missing 1ada25c684c79c9f/2023-12-22--20-22-22, but the engine was likely turned off and the car was in some weird state since CAN was invalid and other ECUs were missing on all buses.

@sshane sshane marked this pull request as ready for review February 28, 2024 02:20
@sshane
Copy link
Contributor Author

sshane commented Feb 28, 2024

Running final test now: 21bf0bb

Looks good, no failures!

@commaai commaai deleted a comment from github-actions bot Feb 28, 2024
@commaai commaai deleted a comment from github-actions bot Feb 28, 2024
@sshane
Copy link
Contributor Author

sshane commented Feb 28, 2024

it works! 440a155809ba2b6d/2024-02-27--20-06-38

@sshane sshane merged commit ce6637c into master Feb 28, 2024
26 of 27 checks passed
@sshane sshane deleted the honda-accord-obd-less branch February 28, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific honda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant