-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honda Odyssey 2018 EX-L with Honda Sensing #155
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6752959
Add odyssey fingerprint
energee 8a6f7a5
Add carstate changes
energee a54b35a
Add odyssey car params to interface
energee 8eebd19
Add carcontroller changes
energee e9c477d
Add hondacan changes
energee 13145dd
Packet size off on a fingerprint id
energee 791a440
Wrong value for MAIN_ON
energee c2972a8
Park Brake not yet in DBC
energee 2552aa4
BRAKE_HOLD signal not ready yet
energee 4009477
Car_gas 130 missing canbus, using 17c
energee fac22f4
Gear shifter values like acura
energee 71057c5
Tuning specific to odyssey
energee 8ff147d
Added the extra carstate reads
energee 8e264ba
SteerRatio should be 14.35
energee 715771b
Unnecessary characters in comma's dongle id
energee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,7 +104,7 @@ def __init__(self, CP, sendcan=None): | |
# self.accord_msg = [] | ||
raise NotImplementedError | ||
|
||
if not self.CS.civic: | ||
if not self.CS.civic and not self.CS.odyssey: | ||
self.compute_gb = get_compute_gb_acura() | ||
else: | ||
self.compute_gb = compute_gb_honda | ||
|
@@ -205,6 +205,18 @@ def get_params(candidate, fingerprint): | |
ret.steerRatio = 15.3 | ||
ret.steerKp, ret.steerKi = 0.8, 0.24 | ||
|
||
ret.longitudinalKpBP = [0., 5., 35.] | ||
ret.longitudinalKpV = [1.2, 0.8, 0.5] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the brake system like the one on the civic or like the one on the acura ILX you think? Can you hear constant pump noise when brakes are applied at low speed? If so, it's probably like the acura and this tuning is fine. |
||
ret.longitudinalKiBP = [0., 35.] | ||
ret.longitudinalKiV = [0.18, 0.12] | ||
elif candidate == "HONDA ODYSSEY 2018 EX-L": | ||
stop_and_go = False | ||
ret.mass = 4354./2.205 + std_cargo | ||
ret.wheelbase = 3.00 | ||
ret.centerToFront = ret.wheelbase * 0.41 | ||
ret.steerRatio = 14.35 | ||
ret.steerKp, ret.steerKi = 0.6, 0.18 | ||
|
||
ret.longitudinalKpBP = [0., 5., 35.] | ||
ret.longitudinalKpV = [1.2, 0.8, 0.5] | ||
ret.longitudinalKiBP = [0., 35.] | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove xxx? @energee