Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2017 Pilot #159

Closed
wants to merge 19 commits into from
Closed

2017 Pilot #159

wants to merge 19 commits into from

Conversation

vanillagorillaa
Copy link
Contributor

Just needs to be tested

@energee
Copy link
Contributor

energee commented Dec 9, 2017

Can you give me commit access to this repo?

@vanillagorillaa
Copy link
Contributor Author

@energee Should be set

rbiasini
rbiasini reviewed Dec 14, 2017
View reviewed changes
selfdrive/car/honda/interface.py
@@ -204,6 +204,32 @@ def get_params(candidate, fingerprint):
ret.longitudinalKpV = [1.2, 0.8, 0.5]
ret.longitudinalKiBP = [0., 35.]
ret.longitudinalKiV = [0.18, 0.12]
elif candidate == "HONDA ODYSSEY 2018 EX-L":
stop_and_go = False
ret.m = 4354./2.205 + std_cargo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these variable names are old. Looks like you need to rebase your branch with latest devel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbiasini My branch is based off of @energee 's branch for easier merging of Odyssey port and Pilot Port. Would you rather have me change variable names in this PR or submit new PR with updated variables

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanillagorillaa , up to you. You can either:

  • create a PR based off master
  • wait on @energee to rebase his branch and then rebase yours.

Since the 2 PR's should't intersect, maybe 1 is better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase first

legonigel pushed a commit that referenced this pull request Feb 21, 2019
Squashed 'panda/' changes from 9ee6285..39c1e39
a25e215 
39c1e39 Cadillac: added brake msg forwarding
aaa1b14 bump VERSION
e0dd558 Fixed undefined reference error when "make recover" in EON
c91f038 Toyota pedal support (#159)
de1ba06 Build optimizer: back to Os now that 'make --recover' is fixed
fd23383 add -lgcc flag to fix "undefined reference to __aeabi_llsr" (#156)
1cc74e2 Reverted code optimizer option to O2 after 'make recover' broke
1218d09 Cadillac ascm proxy (#155)
064446f Panda: bumped version
93266a9 Hyundai: allow the same max steer torque as stock
d275fa8 Subaru: Forwarding (#152)

git-subtree-dir: panda
git-subtree-split: 39c1e39
emmertex pushed a commit to emmertex/openpilot that referenced this pull request Feb 23, 2019
Squashed 'panda/' changes from 9ee6285..aaa1b14
dc3c0ae 
aaa1b14 bump VERSION
e0dd558 Fixed undefined reference error when "make recover" in EON
c91f038 Toyota pedal support (commaai#159)
de1ba06 Build optimizer: back to Os now that 'make --recover' is fixed
fd23383 add -lgcc flag to fix "undefined reference to __aeabi_llsr" (commaai#156)
1cc74e2 Reverted code optimizer option to O2 after 'make recover' broke
1218d09 Cadillac ascm proxy (commaai#155)
064446f Panda: bumped version
93266a9 Hyundai: allow the same max steer torque as stock
d275fa8 Subaru: Forwarding (commaai#152)

git-subtree-dir: panda
git-subtree-split: aaa1b14
adhintz added a commit to adhintz/openpilot that referenced this pull request Feb 24, 2019
@adhintz
0.5.9 version (#16)
c263943 
* Add "Accept-Encoding: gzip" header to mapd.py to reduce data consumption (commaai#525)

* Allow uploader.py to compress rlog without upload permission (commaai#471)

* Always Compress - Make sure uploader to bzip2 rlog once it's completed without any upload permission.

* Squashed 'panda/' changes from 9ee6285..39c1e39

39c1e39 Cadillac: added brake msg forwarding
aaa1b14 bump VERSION
e0dd558 Fixed undefined reference error when "make recover" in EON
c91f038 Toyota pedal support (commaai#159)
de1ba06 Build optimizer: back to Os now that 'make --recover' is fixed
fd23383 add -lgcc flag to fix "undefined reference to __aeabi_llsr" (commaai#156)
1cc74e2 Reverted code optimizer option to O2 after 'make recover' broke
1218d09 Cadillac ascm proxy (commaai#155)
064446f Panda: bumped version
93266a9 Hyundai: allow the same max steer torque as stock
d275fa8 Subaru: Forwarding (commaai#152)

git-subtree-dir: panda
git-subtree-split: 39c1e39

* Squashed 'opendbc/' changes from b632acf..45c3285

45c3285 Added support to Toyota pedal
cfb7070 Revert "Added pedal support for Toyota"
ca607f4 Added pedal support for Toyota
22efd56 Honda: for simplicity all cars now have BRAKE_HOLD signal
f969de0 Honda Nidec: VSA_STATUS msg is teh same for all
85b0df7 chrysler L gear (commaai#139)
b9618da Update Gear Packet with Eco and Sport button (commaai#135)
5259345 Update DBC for Hyundai Kona Support (commaai#138)
608caba Create subaru_outback_2015_eyesight.dbc (commaai#137)

git-subtree-dir: opendbc
git-subtree-split: 45c3285

* Squashed 'pyextra/' changes from 8cc1594..0d19c13

0d19c13 Revert adding reverse_geocoder
4a22fac Fix reverse_geocoder folder
35308c5 Add reverse_geocoder

git-subtree-dir: pyextra
git-subtree-split: 0d19c13e6e4e5fa82a470374146a86dc5d5afa35

* openpilot v0.5.9 release

* remove unneeded msg variable
minimize diff with upstream

* change error back to perm

* allow it to instantly ramp down to 0

* try new panda safety code

* minor panda cleanup
mespiritu pushed a commit to mespiritu/openpilot that referenced this pull request Apr 3, 2019
@arne182
Merge pull request commaai#159 from arne182/spinnerfix
bbbb638 
Spinnerfix
pd0wm pushed a commit that referenced this pull request May 20, 2019
Squashed 'opendbc/' changes from 0875762..4fc6f63
99c81d2 
4fc6f63 Update metric value for Dash_Units (#164)
340ca18 Subaru: added lane line visibility to ES_LKAS message
6b1246d Subaru: added hud unit selection
829ca5e Update subaru_outback_2015_eyesight.dbc (#163)
5d884df add Chrysler ACC resume button (#161)
ba2a69b DBC for the Bosch Radar for Tesla (#158)
7aacee1 Lexus GS300h 2017 DBC (#159)
d6eb4ae Rav4 2019 ADAS (#160)

git-subtree-dir: opendbc
git-subtree-split: 4fc6f63
avolmensky pushed a commit to avolmensky/openpilot that referenced this pull request Jun 10, 2019
@wocsor @rbiasini
Lexus GS300h 2017 DBC (commaai#159)
7aacee1
avolmensky pushed a commit to avolmensky/openpilot that referenced this pull request Jun 30, 2019
@rbiasini
Toyota pedal support (commaai#159)
c91f038
edukinara pushed a commit to edukinara/openpilot that referenced this pull request Jul 18, 2019
@Gernby
Fix DBC for MOAR awesomeness (commaai#159)
2e9994c
Maelstrom96 pushed a commit to Maelstrom96/openpilot that referenced this pull request Dec 15, 2019
@xx979xx
Merge pull request commaai#159 from xx979xx/HKG_dev
d91f7a6 
update
SebastienLubrano pushed a commit to SebastienLubrano/openpilot that referenced this pull request Aug 9, 2021
@pd0wm
add signal to sentinel (commaai#159)
7609d22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@energee energee energee left review comments

@rbiasini rbiasini rbiasini left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vanillagorillaa @energee @rbiasini