Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2018 Hyundai Sonata #19915

Merged
merged 6 commits into from
Jan 26, 2021
Merged

2018 Hyundai Sonata #19915

merged 6 commits into from
Jan 26, 2021

Conversation

Jon8RFC
Copy link
Contributor

@Jon8RFC Jon8RFC commented Jan 25, 2021 •
edited
Loading

2018 Hyundai Sonata Limited Ultimate (SCC+LKAS)

Checklist

  • [Y] added to README
  • [Y&N] test route added to test_car_models
  • (the above already has a route; my car worked without FPv1 modifications and it was slightly different, but should still be updated to FPv2 anyway)
  • [Y] route with openpilot: 03690f0d837307af|2021-01-25--07-06-52
  • [Y] route with openpilot: 03690f0d837307af|2021-01-20--15-00-10
  • [Y] route with stock system: 03690f0d837307af|2021-01-12--11-25-29
  1. Updated the 2019 Sonata FPv1 to include 2018 Sonata FPv2 (includes all firmware variants I've seen in my logs).
  2. Refactored "Sonata_2019" to "Sonata_LF" (LF = 2015-2019 Sonatas) because the 2016-2018 Sonata Limited Ultimate vehicles with the 2.4L engine also have SCC+LKAS and could eventually be supported. The key factor is the Ultimate package on those year-models to have both SCC and LKAS.

@Jon8RFC
2018 Sonata
252028f
@Jon8RFC
Refactor SONATA_2019 to SONATA_LF
35eb39e 
For future support of 2016-2019 Sonata Limited Ultimate vehicles.
@Jon8RFC
Refactor SONATA_2019 to SONATA_LF
e68dcfd 
For future support of 2016-2019 Sonata Limited Ultimate vehicles.
@Jon8RFC
Add 2018 Sonata fingerprints
b0a3118 
Add FPv1 and FPv2 fingerprints for 2018 Sonata Limited Ultimate (SCC+LKAS)
Refactor SONATA_2019 to SONATA_LF (LF = 2014-2019 Sonatas) for future support of 2016-2019 Sonata Limited Ultimate vehicles.
@Jon8RFC
remove 2018 Sonata FPv1
95a7931
@Jon8RFC Jon8RFC changed the title 2018 Hyundai Sonata FPv2 fingerprints 2018 Hyundai Sonata FPv2 fingerprint Jan 25, 2021
@pd0wm pd0wm changed the title 2018 Hyundai Sonata FPv2 fingerprint 2018 Hyundai Sonata Jan 26, 2021
@pd0wm pd0wm merged commit 9c9add6 into commaai:master Jan 26, 2021
@VirtuallyChris
Copy link
Contributor

What harness do you use with this car?

@Jon8RFC
Copy link
Contributor Author

Jon8RFC commented Jan 29, 2021

What harness do you use with this car?

Hyundai E

cfranyota added a commit to cfranyota/openpilot-retired that referenced this pull request Jan 29, 2021
@cfranyota @deanlee
@adeebshihadeh @pd0wm @Jon8RFC @haraschax @mitchellgoffpc @VirtuallyChris @grekiki2 @gregjhogan @newstackdevelopment @sobomax @ZwX1616
master squash & merge (#105)
ea2ac19 
* Fix loggcatd: removed duplicate call to android_logger_list_free  (commaai#19903)

* more tici tests in jenkins (commaai#19908)

* run loggerd tests on tici

* boardd loopback

* fix up seg length

* this doesn't add more coverage

* make loggerd rotation test more reliable

* OS Updater improvements (commaai#19914)

* Clear hashes before swapping

* add retry logic

* better retry logic

* actually fail on retries exceeded

* qt: default token validity 1 hour

* camera_webcam: add "thumbnail" to Pubmaster (commaai#19919)

* pigeon: use const reference for std::string parameter (commaai#19886)

* make onroad test more reliable

* manager.py broadcast process states (commaai#19880)

* broadcast managerstate

* Remove boardd

* show alert

* only trigger on actually receiving a manager state

* add managerstate to simulation exclude for longitudinal test

* broadcast managerState in process replay

* update alert text

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Panda: replace pthread_mutex with std::mutex (commaai#19909)

* Fix panda:  dangling pointer problem in can_receive (commaai#19892)

* refactor can_receive

* still send empty msg

* dmonitoring_init: use &s->output[0] instead of &s->output (commaai#19918)

* agnos 0.4 (commaai#19924)

* update manifest

* update launch env

* model_init: remove memset (commaai#19921)

* camera_common: rename create_thumbnail to publish_thumbnail (commaai#19920)

* rename create_thumbnail to publish_thumbnail

* check pm

* 2018 Hyundai Sonata (commaai#19915)

* 2018 Sonata

* Refactor SONATA_2019 to SONATA_LF

For future support of 2016-2019 Sonata Limited Ultimate vehicles.

* Refactor SONATA_2019 to SONATA_LF

For future support of 2016-2019 Sonata Limited Ultimate vehicles.

* Add 2018 Sonata fingerprints

Add FPv1 and FPv2 fingerprints for 2018 Sonata Limited Ultimate (SCC+LKAS)
Refactor SONATA_2019 to SONATA_LF (LF = 2014-2019 Sonatas) for future support of 2016-2019 Sonata Limited Ultimate vehicles.

* remove 2018 Sonata FPv1

* Revert change to car name string

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Panda: add can_send buffer caching (commaai#19910)

* can_list_to_can_capnp_cpp: write message directly to the output string (commaai#19912)

* cameras_qcom: fix dangling pointer in fill_frame_image (commaai#19891)

* boardd: use setUbloxRaw to avoid memory alloc&copy in pigeon_publish_raw (commaai#19884)

* use setUbloxRaw to avoid memory copy

* const std::string &dat

* TTYPigeon::send : delete unnecessary temporary variables (commaai#19898)

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* fix boardd loopback test after commaai#19880

* wait for pandad to start boardd

* important for indi (commaai#19926)

* important for indi

* dont change that in this pr

* fix indentation (commaai#19925)

* actually wait for boardd to start

* new ref for rateSteers fix

* Split planner and pathplanner publishing into separate 'publish' methods (commaai#19860)

* Split planner and pathplanner publishing into separate 'publish' methods

* Updated test_following_distance.py

* Combined publish+send_mpc_solution methods

* Civic Hatch Diesel fw (commaai#19929)

* 2021 Toyota Highlander engine fw (commaai#19930)

* fill_frame_data: remove unused paramater cnt (commaai#19936)

* Add Github SSH keys (commaai#19879)

* CameraBuf::acquire : release on failure (commaai#19935)

* Thneed::clinit() : use cl_get_device_id helper(commaai#19934)

* util.h: re-indent function string_format and use const std::string & for read_file (commaai#19931)

* minor wifi improvements (commaai#19938)

Co-authored-by: Comma Device <device@comma.ai>

* wifi connecting is not hidden any more

* vision-only radar toggle (commaai#19849)

* remove legacy reset line support (commaai#19770)

* remove temporary fixes

* tombstoned: fix address offset in string

* hyundai: ability to create ACC messages (commaai#19850)

* hyundai: car state with longitudinal control support (commaai#19851)

* hyundai: add follow distance button (commaai#19852)

* Put bootlog in own folder (commaai#19939)

* put bootlog in own folder

* fix uploader

* remove print statements

* update test

* remove comment

* also write initddata

* remove sentinels from test

* OMXEncoder: add calls to OMX_Init()&OMX_Deinit() (commaai#19905)

* add calls to OMX_Init()&OMX_Deinit()

* fix indentation

* Fix BSM signal for Hyundai Santa Fe (commaai#19855)

* Update Hyundai Santa fe FP and constant

Added fingerprint for hyundai santafe limited 2020 and updated the constant description for class

* Update values.py

* removed duplicate from santafe fwdCamera

* add bsm to santa fe for lane change

* added allow nudgeless bypass

* Revert "added allow nudgeless bypass"

This reverts commit f1a3ede.

* UI: handle alert in function update_alert (commaai#19762)

* handle alert in function update_alert

* use sm->updated

* typo

* fix up encoder test for tici rotation (commaai#19941)

* fix encoder test

* revert for c2

Co-authored-by: Comma Device <device@comma.ai>

* dmonitoring_publish: use kj::ArrayPtr<const float> raw_pred as paramater instead of float (commaai#19916)

* fix updated bug that allows for mismatch openpilot/agnos (commaai#19943)

* don't reflash agnos update if already flashed (commaai#19944)

Co-authored-by: Comma Device <device@comma.ai>

* Revert "OMXEncoder: add calls to OMX_Init()&OMX_Deinit() (commaai#19905)"

This reverts commit 8f00813.

* not relevant at high speed (commaai#19946)

* not relevant at high speed

* update ref

* fix qt UI after commaai#19762

* bootlog: fix dangling pointer problem in logger_build_boot (commaai#19942)

* fix  dangling pointer problem

* logger_build_init_data() has same problem

* return kj::Array<capnp::byte>

* Revert "return kj::Array<capnp::byte>"

This reverts commit 4df4685.

* Empty commit,trigger Build

* fix each segment in a route having a different initial logMonoTime

* C++ swaglog (commaai#19825)

* c++ swaglog

* dd

* continue

* fix valgrind complaints about swaglog

* convert framebuffer to class  (commaai#19800)

* class FrameBuffer

* fix build error

* remove bootlog

* remove cqueue, use class SafeQueue (commaai#19774)

* class SafeQueue

* cleanup includes

* space

* add timeout

use try_poll

* add function empty() & size()

* class SafeQueue

* add timeout

use try_poll

* add function empty() & size()

* rebase master

* rebase master

* for loop

* fix bug

* fix safequeue import

* draw lead indicator in 3D (commaai#19793)

* lead indicator in 3D

* more

* Update selfdrive/ui/ui.cc

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* panda: refactor get_serial, return std::optional<std::string> (commaai#19895)

* Panda: refactor get_firmware_version, return std::optional<std::vector> (commaai#19896)

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Panda: use 'std::atomic<bool> connected' to ensure thread-safety (commaai#19954)

* keyboard.cc: get value by reference in ranged based loop (commaai#19950)

* OmxEncoder:  new function set_state, set and wait state changed  (commaai#19906)

* free buffers after state is loaded

* set_data_blocking

* fix indentation

* Empty commit,trigger Build

* Revert "OmxEncoder:  new function set_state, set and wait state changed  (commaai#19906)"

This reverts commit 36a596e.

* Set "use_bsm" on KIA_NIRO_EV, I've tested it seems to be generating (commaai#19955)

* match driverView with new model

* pyTorch DM (commaai#19760)

* new model files

* no more rot

* no rot no diag switch

* should be correct and cache aware

* 405d7ae

* parse new outputs

* change uncertain policy accordingly

* 1bdbd9ed

* adjust

* 0.5 is fine

* 3d4f9cab

* no face prob no loss

* clean up

* clean up test

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* camerad frame lag/drop jenkins tests (commaai#19945)

* clean up test

* not needed for now

* this be enough

* comment this out

* clean up

* adjust tolerance

* use sof on tici

Co-authored-by: Comma Device <device@comma.ai>

Co-authored-by: Dean Lee <deanlee3@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Jon8RFC <Jon8RFC@users.noreply.github.com>
Co-authored-by: HaraldSchafer <harald.the.engineer@gmail.com>
Co-authored-by: Mitchell Goff <mitchellgoffpc@gmail.com>
Co-authored-by: Chris McCammon <chrismccammon123@gmail.com>
Co-authored-by: grekiki <gregor1234567890@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Greg Hogan <gregjhogan@gmail.com>
Co-authored-by: newstackdevelopment <31353561+newstackdevelopment@users.noreply.github.com>
Co-authored-by: Maksym Sobolyev <sobomax@sippysoft.com>
Co-authored-by: ZwX1616 <zwx1616@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pd0wm pd0wm pd0wm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jon8RFC @VirtuallyChris @pd0wm