Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: draw all radard leads #22901

Merged
merged 6 commits into from
Nov 17, 2021
Merged

ui: draw all radard leads #22901

merged 6 commits into from
Nov 17, 2021

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Nov 14, 2021 •
edited
Loading

This draws any lead that the long MPC would stop for, specifically leads detected by the radar at low speed where the model doesn't agree.

Like in this example, radarState and modelV2 disagree if there's a lead (happens to be a speed bump the radar is picking up in low speed override mode). It could be confusing why the car is stopping or not accelerating when there's no indication of a lead on the screen. Just a temp fix. Real fix: remove radard

(f15e3c37c118e841|2021-11-13--17-47-08--34)
Screenshot from 2021-11-13 19-29-48

@sshane sshane changed the title Display all leads where MPC would stop for Display all leads that MPC would stop for Nov 14, 2021
@sshane sshane changed the title Display all leads that MPC would stop for u: display all leads that MPC would stop for Nov 14, 2021
@sshane sshane changed the title u: display all leads that MPC would stop for ui: display all leads that MPC would stop for Nov 14, 2021
@haraschax
Copy link
Contributor

I was hoping to remove radard or at least radar override, but both seemed to be useful according to latest tests, so those are staying for a while. Let's just always draw the radard leads again?

@sshane sshane changed the title ui: display all leads that MPC would stop for ui: draw all radard leads Nov 17, 2021
@sshane @pd0wm
draw leads detected from radar since it has a low speed override
18ab810
@sshane @pd0wm
comment
654ea5e
@sshane @pd0wm
fill lead_verticies
00a0c5a
@sshane @pd0wm
fix
f1f9afe
@sshane @pd0wm
Revert changes
0858d9d 
Revert "fix"

This reverts commit 7a478c4.

Revert "fill lead_verticies"

This reverts commit 5cdf265.

Revert "comment"

This reverts commit 24a8a3f.

Revert "draw leads detected from radar since it has a low speed override"

This reverts commit 4679fa5.
@sshane @pd0wm
Revert "Draw model leads (commaai#21864)"
f3a496f 
This commit reverts 276b00c
@pd0wm pd0wm merged commit fa55dbe into commaai:master Nov 17, 2021
@sshane sshane deleted the display-radar-leads branch November 17, 2021 13:30
@sshane sshane mentioned this pull request Jan 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haraschax haraschax Awaiting requested review from haraschax

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sshane @haraschax @pd0wm