networking: cleanup&optimize WifiManager #23455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
ui_network
branch
5 times, most recently
from
a7a898f
to
79df9d0
Compare
deanlee
changed the title
|
doun't know why failed to build docs |
|
@adeebshihadeh Why does the "build docs" fail? Have I done something wrong? |
|
Looks like this is the issue https://github.com/michaeljones/breathe/pull/618/files use |
|
Let's make sure to not make the PR too big, so it's hard to review. Feel free to split this up if something's already done and self-contained. |
This was referenced Jan 14, 2022
|
closed.it's all split up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next PR: I plan to use QDBusAbstractInterface::asyncCall in WifiManager::call to solve the blocking problemi'll do async scan/refresh in this prresolve: #23445