networking: cleanup&optimize WifiManager

selfdrive/ui/qt/offroad/networking.cc

@@ -100,13 +100,11 @@ void Networking::wrongPassword(const QString &ssid) {
 }
 
 void Networking::showEvent(QShowEvent* event) {
-  // Wait to refresh to avoid delay when showing Networking widget
-  QTimer::singleShot(300, this, [=]() {
-    if (this->isVisible()) {
-      wifi->refreshNetworks();
-      refresh();
-    }
-  });
+  wifi->start();
+}
+
+void Networking::hideEvent(QHideEvent* event) {
+  wifi->stop();
 }
 
 // AdvancedNetworking functions
@@ -141,7 +139,7 @@ AdvancedNetworking::AdvancedNetworking(QWidget* parent, WifiManager* wifi): QWid
   list->addItem(editPasswordButton);
 
   // IP address
-  ipLabel = new LabelControl("IP Address", wifi->ipv4_address);
+  ipLabel = new LabelControl("IP Address");
   list->addItem(ipLabel);
 
   // SSH keys
@@ -266,7 +264,7 @@ void WifiUI::refresh() {
     return;
   }
   QList<Network> sortedNetworks = wifi->seenNetworks.values();
-  std::sort(sortedNetworks.begin(), sortedNetworks.end(), compare_by_strength);
+  std::sort(sortedNetworks.begin(), sortedNetworks.end(), compare_network);
 
   // add networks
   ListWidget *list = new ListWidget(this);

selfdrive/ui/qt/offroad/networking.h

@@ -65,6 +65,7 @@ class Networking : public QFrame {
 
 protected:
   void showEvent(QShowEvent* event) override;
+  void hideEvent(QHideEvent* event) override;
 
 public slots:
   void refresh();