paramsd: use real logMonoTime #24279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No. Is this more correct? Only case I can think of is in the downstream analysis if the carstate logmonotime is very far off from actual logmonotime |
|
Yes, logMonoTime should be timestamped in the process building/sending the message. For cases where we want to track the source info, we add a field with a frame ID or logMonoTime, e.g. |
spektor56
pushed a commit
to spektor56/ghostpilot
that referenced
this pull request
May 7, 2022
ntoenis
pushed a commit
to ntoenis/openpilot
that referenced
this pull request
May 31, 2022
This reverts commit 4c90208.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything rely on this @nuwandavek?