-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Pedal Fingerprints for Honda and small change to Pilot / Ridgeline steerKpV and steerKiV to fit 3.3333 ratio #268
Conversation
@jfrux looks good. Can you please add a comment that 512 and 513 are reserved comma pedal? Also, I would prefer to leave the toyota changes out for now, as pedal isn't supported for toyota vehicles yet. |
Not sure if this should go into this PR though or not. This makes the ratio match the other vehicles in the file. Otherwise it's 3.454545...
@rbiasini Do you want the comments + the 512, 513's to be on a new line similar to how the sent messages were before? Example: ...
CAR.PILOT: [{
57L: 3, 145L: 8, 228L: 5, 229L: 4, 308L: 5, 316L: 8, 334L: 8, 339L: 7, 342L: 6, 344L: 8, 379L: 8, 380L: 8, 392L: 6, 399L: 7, 419L: 8, 420L: 8, 422L: 8, 425L: 8, 426L: 8, 427L: 3, 432L: 7, 463L: 8, 464L: 8, 476L: 4, 490L: 8, 506L: 8, 507L: 1, 538L: 3, 542L: 7, 545L: 5, 546L: 3, 597L: 8, 660L: 8, 773L: 7, 777L: 8, 780L: 8, 795L: 8, 800L: 8, 804L: 8, 808L: 8, 819L: 7, 821L: 5, 829L: 5, 837L: 5, 856L: 7, 871L: 8, 882L: 2, 884L: 7, 891L: 8, 892L: 8, 923L: 2, 929L: 8, 963L: 8, 965L: 8, 966L: 8, 967L: 8, 983L: 8, 985L: 3, 1027L: 5, 1029L: 8, 1036L: 8, 1039L: 8, 1064L: 7, 1088L: 8, 1089L: 8, 1108L: 8, 1125L: 8, 1296L: 8, 1424L: 5, 1600L: 5, 1601L: 8, 1612L: 5, 1613L: 5, 1616L: 5, 1618L: 5, 1668L: 5,
# Comma Pedal Support
512L: 6, 513L: 6,
}],
... OR ...
# 2017 Pilot Touring and 2016 Pilot EX-L
# with Comma Pedal Support (512L & 513L)
CAR.PILOT: [{
57L: 3, 145L: 8, 228L: 5, 229L: 4, 308L: 5, 316L: 8, 334L: 8, 339L: 7, 342L: 6, 344L: 8, 379L: 8, 380L: 8, 392L: 6, 399L: 7, 419L: 8, 420L: 8, 422L: 8, 425L: 8, 426L: 8, 427L: 3, 432L: 7, 463L: 8, 464L: 8, 476L: 4, 490L: 8, 506L: 8, 507L: 1, 512L: 6, 513L: 6, 538L: 3, 542L: 7, 545L: 5, 546L: 3, 597L: 8, 660L: 8, 773L: 7, 777L: 8, 780L: 8, 795L: 8, 800L: 8, 804L: 8, 808L: 8, 819L: 7, 821L: 5, 829L: 5, 837L: 5, 856L: 7, 871L: 8, 882L: 2, 884L: 7, 891L: 8, 892L: 8, 923L: 2, 929L: 8, 963L: 8, 965L: 8, 966L: 8, 967L: 8, 983L: 8, 985L: 3, 1027L: 5, 1029L: 8, 1036L: 8, 1039L: 8, 1064L: 7, 1088L: 8, 1089L: 8, 1108L: 8, 1125L: 8, 1296L: 8, 1424L: 5, 1600L: 5, 1601L: 8, 1612L: 5, 1613L: 5, 1616L: 5, 1618L: 5, 1668L: 5
}],
... Going with option 2 for now until I hear back. |
Another question, should I add logic for Pedal support and |
Okay so we still need to warn steering on cars that have a cut off on steering at the ECU. It now just shows as engaged always down to zero. |
- Slight comment update to Ridgeline
0430bfa5 run pre commit in ci (#268) 2ade6eeb Subaru DBC update (#242) d1185a53 Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258) e6766bbb Update SCC ECU Messages for OP Long Dev. (#267) b49b9ee7 Add DAW (#175) 3b5cccba Fixed up cell voltage readings and added more commands (#220) 8b044932 Mazda: add missing static bits, tidy up endianness (#263) 12471999 Add BSD_RCTA to Subaru Global (#244) af1821f8 fix endianness in signal from new hyundai message 7ef41084 Add gas/brake message for hyundai EVs, from @TK211X 472aabb4 Subaru preglobal update (#260) 45c0d9ec fix lta message (#262) 11343c10 Library cleanup (#261) 67d70cb8 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: 0430bfa5c2b08f9cc6ab32470fe8ac9465e7a876
0430bfa5c run pre commit in ci (#268) 2ade6eeba Subaru DBC update (#242) d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258) e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267) b49b9ee75 Add DAW (#175) 3b5cccba0 Fixed up cell voltage readings and added more commands (#220) 8b0449327 Mazda: add missing static bits, tidy up endianness (#263) 124719992 Add BSD_RCTA to Subaru Global (#244) af1821f84 fix endianness in signal from new hyundai message 7ef41084b Add gas/brake message for hyundai EVs, from @TK211X 472aabb4f Subaru preglobal update (#260) 45c0d9ecc fix lta message (#262) 11343c108 Library cleanup (#261) 67d70cb86 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: 0430bfa5c2b08f9cc6ab32470fe8ac9465e7a876
e92e74311 whitespace after comma 5d33ec0f1 two spaces before inline comment 73685b609 fix linter complaint about whitespace around operators b15edbc1b fix linter complaint about inline comment whitespace 4ac30725b clean up blank lines 0430bfa5c run pre commit in ci (#268) 2ade6eeba Subaru DBC update (#242) d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258) e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267) b49b9ee75 Add DAW (#175) 3b5cccba0 Fixed up cell voltage readings and added more commands (#220) 8b0449327 Mazda: add missing static bits, tidy up endianness (#263) 124719992 Add BSD_RCTA to Subaru Global (#244) af1821f84 fix endianness in signal from new hyundai message 7ef41084b Add gas/brake message for hyundai EVs, from @TK211X 472aabb4f Subaru preglobal update (#260) 45c0d9ecc fix lta message (#262) 11343c108 Library cleanup (#261) 67d70cb86 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: e92e74311a7ed66922629bec4b8cee7c8db1b9f0
4c59163aa two spaces before inline comment e92e74311 whitespace after comma 5d33ec0f1 two spaces before inline comment 73685b609 fix linter complaint about whitespace around operators b15edbc1b fix linter complaint about inline comment whitespace 4ac30725b clean up blank lines 0430bfa5c run pre commit in ci (#268) 2ade6eeba Subaru DBC update (#242) d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258) e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267) b49b9ee75 Add DAW (#175) 3b5cccba0 Fixed up cell voltage readings and added more commands (#220) 8b0449327 Mazda: add missing static bits, tidy up endianness (#263) 124719992 Add BSD_RCTA to Subaru Global (#244) af1821f84 fix endianness in signal from new hyundai message 7ef41084b Add gas/brake message for hyundai EVs, from @TK211X 472aabb4f Subaru preglobal update (#260) 45c0d9ecc fix lta message (#262) 11343c108 Library cleanup (#261) 67d70cb86 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: 4c59163aa31b58436fad2f8cbadeacd564887276
1f1ff225b enable almost all flake8 checks 4c59163aa two spaces before inline comment e92e74311 whitespace after comma 5d33ec0f1 two spaces before inline comment 73685b609 fix linter complaint about whitespace around operators b15edbc1b fix linter complaint about inline comment whitespace 4ac30725b clean up blank lines 0430bfa5c run pre commit in ci (#268) 2ade6eeba Subaru DBC update (#242) d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258) e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267) b49b9ee75 Add DAW (#175) 3b5cccba0 Fixed up cell voltage readings and added more commands (#220) 8b0449327 Mazda: add missing static bits, tidy up endianness (#263) 124719992 Add BSD_RCTA to Subaru Global (#244) af1821f84 fix endianness in signal from new hyundai message 7ef41084b Add gas/brake message for hyundai EVs, from @TK211X 472aabb4f Subaru preglobal update (#260) 45c0d9ecc fix lta message (#262) 11343c108 Library cleanup (#261) 67d70cb86 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: 1f1ff225bd03b273a4861a67d96d4e53d7ce542c
1f1ff225b enable almost all flake8 checks 4c59163aa two spaces before inline comment e92e74311 whitespace after comma 5d33ec0f1 two spaces before inline comment 73685b609 fix linter complaint about whitespace around operators b15edbc1b fix linter complaint about inline comment whitespace 4ac30725b clean up blank lines 0430bfa5c run pre commit in ci (#268) 2ade6eeba Subaru DBC update (#242) d1185a53e Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258) e6766bbbb Update SCC ECU Messages for OP Long Dev. (#267) b49b9ee75 Add DAW (#175) 3b5cccba0 Fixed up cell voltage readings and added more commands (#220) 8b0449327 Mazda: add missing static bits, tidy up endianness (#263) 124719992 Add BSD_RCTA to Subaru Global (#244) af1821f84 fix endianness in signal from new hyundai message 7ef41084b Add gas/brake message for hyundai EVs, from @TK211X 472aabb4f Subaru preglobal update (#260) 45c0d9ecc fix lta message (#262) 11343c108 Library cleanup (#261) 67d70cb86 Fix Toyota message size git-subtree-dir: opendbc git-subtree-split: 1f1ff225bd03b273a4861a67d96d4e53d7ce542c
This is based on Joel's Pedal PR but should contain changes from #251
0.4.7.1
release.selfdrive/car/honda/values.py
to explain the Pedal changes.