Adds Pedal Interceptor Support for Honda & Acura Vehicles #274

jfrux · 2018-06-26T15:39:42Z

This PR is for Honda and Acura Pedal on 0.5.x.

Todo

ADDED

Not sure if this should go into this PR though or not. This makes the ratio match the other vehicles in the file. Otherwise it's 3.454545...

- Slight comment update to Ridgeline

- Adds steering warning for interceptor cars in low speed lockout.

jfrux · 2018-06-26T17:02:40Z

The updates to the warning messages haven't been tested yet but will be testing these changes to see if maybe this is where the degraded functionality came from during the 0.4.7 update.

Pedal cars lost their warning for some reason during 0.4.7 so this is the only thing I can see that might have caused it.

jfrux · 2018-06-26T20:23:14Z

Confirmed this is working great on the 2017 Honda Pilot Touring.
Seeking more testers for Odyssey (@joeljacobs), Ridgeline, and RDX (@rinterdonato)

jfrux · 2018-06-27T14:06:44Z

Continued stability on my Pilot commute this morning.

2017 Honda Pilot

2 hours+ of testing usage so far on highways.
No longer allows you to enable at zero for safety.
Allows steer status of 3 to trigger steer_warning since this is required for safety below 12 mph.
Does stop and go with Pedal down to zero.

2018 Odyssey

No testing has been done at this point.
Might allow enabling at zero even without a lead car (which not sure if that's recommended)
No longer uses 3 in warnings like the rest of the stop and go cars that steer to zero.

2018 RDX

Did get the PR in the hands of an RDX owner (@rinterdonato). Have not confirmed he has tested yet.
Needs confirmed whether this should warn under 12mph or if it should not warn down to zero due to it's ability to steer to zero like the Odyssey
No longer uses 3 in warnings like the rest of the stop and go cars that steer to zero. (assuming it steers to zero because @rinterdonato claims the car steers to zero.

rinterdonato · 2018-06-27T15:15:15Z

RDX testing has not occurred yet. Planned for tonight. Sent from Mail for Windows 10 From: Joshua F. Rountree Sent: Wednesday, June 27, 2018 8:07 AM To: commaai/openpilot Cc: Rich Interdonato; Mention Subject: Re: [commaai/openpilot] Adds Pedal Interceptor Support for Honda &Acura Vehicles (#274) Continued stability on my Pilot commute this morning. 2017 Honda Pilot • 2 hours+ of testing usage so far on highways. • No longer allows you to enable at zero for safety. • Allows steer status of 3 to trigger steer_warning since this is required for safety below 12 mph. • Does stop and go with Pedal down to zero. ** 2018 Odyssey** • No testing has been done at this point. • Might allow enabling at zero even without a lead car (which not sure if that's recommended) • No longer uses 3 in warnings like the rest of the stop and go cars that steer to zero. 2018 RDX • Did get the PR in the hands of an RDX owner (@rinterdonato). Have not confirmed he has tested yet. • Needs confirmed whether this should warn under 12mph or if it should not warn down to zero due to it's ability to steer to zero like the Odyssey • No longer uses 3 in warnings like the rest of the stop and go cars that steer to zero. (assuming it steers to zero because @rinterdonato claims the car steers to zero. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jfrux · 2018-06-29T23:16:52Z

2018 RDX Testing was Successful fyi.

jfrux · 2018-06-29T23:17:34Z

And I altered it to warn at 12mph of steering warning because it doesn't steer below 12mph.

jfrux · 2018-07-02T01:08:11Z

Getting reports on an Odyssey Elite that is not working with Pedal.
Guessing something strange with the DBC or something.

rbiasini · 2018-07-06T23:36:16Z

@jfrux not all the hondas have the same pedal wiring. Maybe that's the issue with the Odissey?

jfrux · 2018-07-07T00:40:51Z

@rbiasini Realizing that the Elite has never been working with Pedal yet. That's something unrelated and we will just have to remove support for Elite for Pedal for this PR.

RDX, Pilot, and Odyssey (regular) are solid, wondering if we can move forward by just these and I can remove Pedal from the Odyssey Elite for now and then I can work with Odyssey Elite when I get time.

I'll get this updated soon.

rbiasini · 2018-07-11T01:52:16Z

@jfrux a lot more changes seem to have slipped onto this PR. Can't we just merge the fingerprints for now?

energee · 2018-07-11T03:52:31Z

README.md

@@ -45,23 +45,45 @@ Supported Cars
  - Due to limitations in steering firmware, steering is disabled below 12 mph
  - Uses stock Honda Sensing for longitudinal control

- Honda CR-V Touring 2015-2016
+- Honda CR-V Touring 2015-2016 with Honda Sensing


It was intentional to leave off "with Honda Sensing". This is redundant because Honda Sensing is not an option, it is standard on touring trim, and touring only for these years

The whole file is redundant. The supported vehicles don’t belong on the readme. They belong on the wiki or a linked md so we can dig deeper.

The code base has vehicles hardcoded. If we’re writing if car.PILOT we are doing it wrong in the end.

It must be feature based or at the very least year make model based. I get that it was mostly for rapid prototyping purposes but it’s all redundant in the end game.

To truly inspire, we will have to move away from the majority of how things are written. But baby steps I suppose. :D

README went through big changes for 0.5 release. Better to revert the changes to this file.

Fair enough, will do!

rbiasini · 2018-07-11T18:37:05Z

@jfrux , see my latest comments

jfrux · 2018-07-11T18:45:33Z

@rbiasini Okay, made the changes you requested.
Will await your comments if any are necessary.

rbiasini · 2018-07-11T18:58:56Z

README.md

@@ -184,4 +184,4 @@ Any user of this software shall indemnify and hold harmless Comma.ai, Inc. and i

 **THIS IS ALPHA QUALITY SOFTWARE FOR RESEARCH PURPOSES ONLY. THIS IS NOT A PRODUCT.
 YOU ARE RESPONSIBLE FOR COMPLYING WITH LOCAL LAWS AND REGULATIONS.
-NO WARRANTY EXPRESSED OR IMPLIED.**
+NO WARRANTY EXPRESSED OR IMPLIED.**


this is already added to the internal README

I'm thinking maybe it was a line spacing issue or something? I just pasted the main README.md from the previous version...

rbiasini · 2018-07-11T18:59:54Z

@jfrux not sure why the diff shows weird changes to submodule refs.

jfrux · 2018-07-11T19:01:43Z

Aww crap, that may have been remnants from something else I was working on before... that's weird that it left them in this branch. Very odd.

Let me look into that real quick.

jfrux · 2018-07-11T19:07:44Z

Fixed, removed those submodules. OOPS! :)

…issues.

jfrux · 2018-07-12T21:37:39Z

You thinking we good then on this since those issues have been handled?

jfrux · 2018-07-13T03:35:26Z

Updated to support v0.5.x from what I can tell it's all working. Testing now.

jfrux · 2018-07-13T17:24:23Z

Realized that last night I didn't add the fingerprints back in after fixing the merge.
I just did now. Going to be testing this will let you know.

jfrux

LGTM

* Adds Joel's Changes to values, sorted as Rick wanted. * Adds space at end of file. * Adds Changes to Steering Ratio for Pilot testing. * Adding this to steer ratio makes it even 3.33 Not sure if this should go into this PR though or not. This makes the ratio match the other vehicles in the file. Otherwise it's 3.454545... * Changes the RAV4 back to not include pedal. * Updated Comments for Pedal Support * - Adds menuever test output to gitignore. - Slight comment update to Ridgeline * - Cleanup steer status comments - Adds steering warning for interceptor cars in low speed lockout. * Cleans up comments. * Update README.md * Corrects verbiage in README regarding Comma Pedal on Honda's * Updates Odyssey and MDX to not add extra warnings for low-speed-lockout. * Updates Comma Pedal references to use anchor links. * Minor tweak to README * Updates RDX to warn no steering below 12mph * Reverts changes to README, carstate.py, and interface.py * Removes extra libraries from a prior experiment. * Replaces README with one from current devel. Hope this fixes spacing issues. * Adds Pedal back to Honda Cars and sorts fingerprint values * Fixes spacing changes that were not intentional. * Fixed carstate no newline at end of file. * Fixes new line at end of file issue. * Converted the Long's to Int's

256d274 Fix Mac installation instruction per: https://github.com/commaai/panda/pull/308/files bfd8ff1 Update cppcheck commit with more coverage b143a1c Fixed Misra complaint 606f1d9 Fixed RTC on non-uno boards, second try. Cannot work when there is no xtal. 933c757 Fix RTC on non-uno boards (#311) 48d0d0c VW button spam: fix safety and add tests (#306) 6cccf96 Fan and IR at 0 when in power savings mode (#309) 0537328 board get_sdk scripts were left on python2 de18a7e bump version after uno merge 1965817 Changed default values for testing a12a148 Uno (#274) 7d29dc5 bump panda version. We really need a better way 4007532 VW: stricter limits to comply with comma safety policy e2e2be9 add safety mode to health packet 101238c turned on VW ignition based CAN logic a0d8d5d fix misra 5.3: check_ignition is intended as check_started and can't be used twice ea636de made check_ignition function to both look at ignition_line and ignition_can 1102e69 make ignition logic common for all cars (#303) 3a110c6 bump version after CMSIS core upgrade 55dfa52 Update core to CMSIS 5.6 release (#251) ee86490 fix linter 2 f410b11 fix linter 55957d6 proper python3 exception inheritance 6ba0f47 fix linter errors 5c49fe0 Merge pull request #145 from gregjhogan/uds 0f36199 timeout is float 396d6aa safety_replay only installs few extra requirements 25af7d3 Misra also need python 3 env 7434c5c centralize requirements for tests a0c37c7 coverage not needed in linter reqs fce38a9 Linter python (#299) 62e2f5c update cppcheck commit 711810d more uds debug 4454e3a better CAN comm abstraction 6b1f28f fix more encoding and some bytes cleanup (#300) 43adad3 fix WARNING_INDICATOR_REQUESTED name 9c857da 0x b64d6fa typing 768fdf7 bytes() > chr().encode() 1be15ea custom errors from thread 68da831 more python3 eb358e8 uds lib example 4f28858 updates for python3 932745f support tx flow control for chunked messages b1c3712 add timeout param cdf2f62 bug fixes b1a3195 fix rx message filtering bug 80fb6a6 convert uds lib to class 59cd2b4 handle separation time in microseconds 4429600 fix separation time parsing c641e66 fix typo 48b8dcc fix flow control delay scale 78f413d flow control delay 33a5167 bug fixes 8ee89a0 multi-frame tx 5e89a9c clear rx buffer and numeric error ids 9662300 fix remaining size calculation 01ef1fa zero pad messages before sending 1ddc973 uds can communication dca176e syntax errors 95be481 SERVICE_TYPE enum 98e73b5 more UDS message type implementation c1c5b03 uds lib 162f485 fix chr to bytes conversions (#298) 4972376 Update VW regression test to follow Comma safety index refactoring (#296) f9053f5 more Python 3 fixes, attempting to fix jenkins wifi regresison test (#295) 2f9e076 Panda safety code for Volkswagen, Audi, SEAT, and Škoda (#293) git-subtree-dir: panda git-subtree-split: 256d274

* Adds Joel's Changes to values, sorted as Rick wanted. * Adds space at end of file. * Adds Changes to Steering Ratio for Pilot testing. * Adding this to steer ratio makes it even 3.33 Not sure if this should go into this PR though or not. This makes the ratio match the other vehicles in the file. Otherwise it's 3.454545... * Changes the RAV4 back to not include pedal. * Updated Comments for Pedal Support * - Adds menuever test output to gitignore. - Slight comment update to Ridgeline * - Cleanup steer status comments - Adds steering warning for interceptor cars in low speed lockout. * Cleans up comments. * Update README.md * Corrects verbiage in README regarding Comma Pedal on Honda's * Updates Odyssey and MDX to not add extra warnings for low-speed-lockout. * Updates Comma Pedal references to use anchor links. * Minor tweak to README * Updates RDX to warn no steering below 12mph * Reverts changes to README, carstate.py, and interface.py * Removes extra libraries from a prior experiment. * Replaces README with one from current devel. Hope this fixes spacing issues. * Adds Pedal back to Honda Cars and sorts fingerprint values * Fixes spacing changes that were not intentional. * Fixed carstate no newline at end of file. * Fixes new line at end of file issue. * Converted the Long's to Int's

* Added uno * Added usb switch support * Added PWM and IR power functions * Implemented bootkick * Added uno as a new hw type * Bumped version * Added fan control and tach readout * WIP: RTC support * Working RTC * Fixed python * Misra compliance * Added USB control messages for fan/IR power * Added USB commands + tests for fan & IR control. Fixed bootstub and pedal compilation * Added IR and fan to power saving mode * Changed defaults * Fix safety considering uno * passing safety now * Minor UNO tweaks * Fixed version * More minor temporary tweaks * Removed usb load switch from uno * Added power control for shutting down the fan completely * Disable IR LEDs by default * Fixed linter issue * Linter fix #2

* Update accel limits * not as much deceleration * Display slowdown img when either model-related solution are slowing down * tone down deceleration * fix missing var

0.8.16

* MSPA: `lateralPlanSP` legacy support * bump cereal

jfrux and others added 10 commits June 22, 2018 10:28

Adds Joel's Changes to values, sorted as Rick wanted.

a087c05

Adds space at end of file.

ab53c22

Adds Changes to Steering Ratio for Pilot testing.

3bb9a1b

Adding this to steer ratio makes it even 3.33

eb54840

Not sure if this should go into this PR though or not. This makes the ratio match the other vehicles in the file. Otherwise it's 3.454545...

Changes the RAV4 back to not include pedal.

d9dbf43

Updated Comments for Pedal Support

0bbf1cd

- Adds menuever test output to gitignore.

80df262

- Slight comment update to Ridgeline

Merge branch 'devel' into feature/pedal-0.4.7.1

d5c1859

- Cleanup steer status comments

2471a1e

- Adds steering warning for interceptor cars in low speed lockout.

Cleans up comments.

2bb629a

jfrux changed the title ~~Add Pedal Interceptor Support for Honda & Acura Vehicles~~ Adds Pedal Interceptor Support for Honda & Acura Vehicles Jun 26, 2018

Update README.md

6ab21a3

Corrects verbiage in README regarding Comma Pedal on Honda's

e815afd

jfrux mentioned this pull request Jun 26, 2018

Pedal #251

Closed

jfrux added 3 commits June 27, 2018 09:48

Updates Odyssey and MDX to not add extra warnings for low-speed-lockout.

834fb23

Updates Comma Pedal references to use anchor links.

9ac92fb

Minor tweak to README

c4d2f19

jfrux and others added 2 commits June 29, 2018 12:21

Updates RDX to warn no steering below 12mph

2e7b195

Merge branch 'devel' into feature/support-for-comma-pedal

d873cd7

energee reviewed Jul 11, 2018

View reviewed changes

rbiasini closed this Jul 11, 2018

rbiasini reopened this Jul 11, 2018

Reverts changes to README, carstate.py, and interface.py

19b5127

rbiasini reviewed Jul 11, 2018

View reviewed changes

Removes extra libraries from a prior experiment.

8a144b0

Replaces README with one from current devel. Hope this fixes spacing …

ecbaec1

…issues.

Merge branch 'devel' into feature/support-for-comma-pedal

11dd10e

Adds Pedal back to Honda Cars and sorts fingerprint values

1d92ef4

jfrux added 4 commits July 13, 2018 13:25

Fixes spacing changes that were not intentional.

b98ece5

Fixed carstate no newline at end of file.

92d06f2

Fixes new line at end of file issue.

0a2476f

Converted the Long's to Int's

54896cd

rbiasini merged commit ef8e6fb into commaai:devel Jul 14, 2018

jfrux commented Jul 14, 2018

View reviewed changes

zhou13 pushed a commit to zhou13/openpilot that referenced this pull request Nov 21, 2022

Merge pull request commaai#274 from commaai/devel

5829fe0

0.8.16

nworb-cire pushed a commit to opgm/openpilot that referenced this pull request May 21, 2024

MSPA: lateralPlanSP legacy support (commaai#274)

fbabd57

* MSPA: `lateralPlanSP` legacy support * bump cereal

nworb-cire pushed a commit to opgm/openpilot that referenced this pull request Aug 2, 2024

Gap Adjust Cruise: Fix carstate button press logic (commaai#274)

04b6255

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Pedal Interceptor Support for Honda & Acura Vehicles #274

Adds Pedal Interceptor Support for Honda & Acura Vehicles #274

jfrux commented Jun 26, 2018 •

edited

Loading

jfrux commented Jun 26, 2018

jfrux commented Jun 26, 2018

jfrux commented Jun 27, 2018 •

edited

Loading

rinterdonato commented Jun 27, 2018 via email

jfrux commented Jun 29, 2018

jfrux commented Jun 29, 2018

jfrux commented Jul 2, 2018

rbiasini commented Jul 6, 2018

jfrux commented Jul 7, 2018 •

edited

Loading

rbiasini commented Jul 11, 2018

energee Jul 11, 2018

jfrux Jul 11, 2018 •

edited

Loading

rbiasini Jul 11, 2018

jfrux Jul 11, 2018

rbiasini commented Jul 11, 2018

jfrux commented Jul 11, 2018

rbiasini Jul 11, 2018

jfrux Jul 11, 2018

rbiasini commented Jul 11, 2018

jfrux commented Jul 11, 2018

jfrux commented Jul 11, 2018

jfrux commented Jul 12, 2018

jfrux commented Jul 13, 2018

jfrux commented Jul 13, 2018

jfrux left a comment

Adds Pedal Interceptor Support for Honda & Acura Vehicles #274

Adds Pedal Interceptor Support for Honda & Acura Vehicles #274

Conversation

jfrux commented Jun 26, 2018 • edited Loading

Todo

jfrux commented Jun 26, 2018

jfrux commented Jun 26, 2018

jfrux commented Jun 27, 2018 • edited Loading

rinterdonato commented Jun 27, 2018 via email

jfrux commented Jun 29, 2018

jfrux commented Jun 29, 2018

jfrux commented Jul 2, 2018

rbiasini commented Jul 6, 2018

jfrux commented Jul 7, 2018 • edited Loading

rbiasini commented Jul 11, 2018

energee Jul 11, 2018

Choose a reason for hiding this comment

jfrux Jul 11, 2018 • edited Loading

Choose a reason for hiding this comment

rbiasini Jul 11, 2018

Choose a reason for hiding this comment

jfrux Jul 11, 2018

Choose a reason for hiding this comment

rbiasini commented Jul 11, 2018

jfrux commented Jul 11, 2018

rbiasini Jul 11, 2018

Choose a reason for hiding this comment

jfrux Jul 11, 2018

Choose a reason for hiding this comment

rbiasini commented Jul 11, 2018

jfrux commented Jul 11, 2018

jfrux commented Jul 11, 2018

jfrux commented Jul 12, 2018

jfrux commented Jul 13, 2018

jfrux commented Jul 13, 2018

jfrux left a comment

Choose a reason for hiding this comment

jfrux commented Jun 26, 2018 •

edited

Loading

jfrux commented Jun 27, 2018 •

edited

Loading

jfrux commented Jul 7, 2018 •

edited

Loading

jfrux Jul 11, 2018 •

edited

Loading