Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kia: add missing K5 2024 FW #30220

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Kia: add missing K5 2024 FW #30220

merged 2 commits into from
Oct 10, 2023

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Oct 10, 2023

All it took was the extra few months for the camera FW date

lat accel factor and friction match, SCC is from radar

d35187278d48ed36|2023-10-10--16-07-53

All it took was the extra few months for the camera FW date
@github-actions github-actions bot added car vehicle-specific hyundai labels Oct 10, 2023
@github-actions
Copy link
Contributor

⚠️ This PR makes changes to CARS.md ⚠️

🔀 Column Changes

Make Model Supported Package ACC No ACC accel below No ALC below Steering Torque Resume from stop Hardware Needed Video
Kia K5 2021-22 ➡️ K5 2021-24 Smart Cruise Control (SCC) openpilot available1 0 mph 0 mph
Parts- 1 Hyundai A connector
- 1 RJ45 cable (7 ft)
- 1 comma 3X
- 1 comma power v2
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
➡️
Parts- 1 Hyundai A connector
- 1 RJ45 cable (7 ft)
- 1 comma 3X
- 1 comma power v2
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here

@sshane sshane merged commit e030a70 into master Oct 10, 2023
24 checks passed
@sshane sshane deleted the k5-2024 branch October 10, 2023 22:17
],
(Ecu.fwdCamera, 0x7C4, None): [
b'\xf1\x00DL3 MFC AT USA LHD 1.00 1.03 99210-L3000 200915',
b'\xf1\x00DL3 MFC AT USA LHD 1.00 1.04 99210-L3000 210208',
b'\xf1\x00DL3 MFC AT KOR LHD 1.00 1.04 99210-L2000 210527',
b'\xf1\x00DL3 MFC AT USA LHD 1.00 1.05 99210-L3000 211222',
Copy link
Contributor Author

@sshane sshane Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, from #31345, this car is reporting this as the manufacturing date which makes sense since it's a 2024 MY:

b' #\x06\x10'.hex()
Out[9]: '20230610'

So could the date in the full string be the date the FW was published or flashed? @gregjhogan do you know if 0xF18B/ECU_MANUFACTURING_DATE is usually only the physical part date, and not anything else like FW version flash date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant