Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: log camera manufacture date #31345

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Hyundai: log camera manufacture date #31345

merged 4 commits into from
Feb 7, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Feb 7, 2024

For #31254

@sshane sshane changed the title Hyundai: log camera manufacturing date Hyundai: log camera manufacture date Feb 7, 2024
@github-actions github-actions bot added car vehicle-specific hyundai labels Feb 7, 2024
@sshane
Copy link
Contributor Author

sshane commented Feb 7, 2024

We can also just append this DID to the RDBI query, but that changes the FW version. Ideally we can store different parameters per-ECU, in addition to one main FW version. For example, for the camera, it could store the part number, the manufacture date, and the platform code as separate lists in a dict for easy lookup.

Brand: hyundai, bus: 0 - (Ecu.fwdCamera, 0x7c4, None): [b'\xf1\x00JFA LKAS AT USA LHD 1.00 1.00 95895-D5001 h32\xf1\x8b \x19\x03$']

We will potentially need this for the Bolt, as their version of UDS doesn't support tacking on multiple DIDs to one read data by id query, you have to get them separately.

Comment on lines +458 to +459
[HYUNDAI_ECU_MANUFACTURING_DATE],
[HYUNDAI_VERSION_RESPONSE],
Copy link
Contributor Author

@sshane sshane Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be the calibration/programming date, and the date in the full FW version string may be the manufacture date, as on the EV6, this date was 2 months after the date in the string, not before

Copy link
Contributor Author

@sshane sshane Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b'\xf1\x00CV1 MFC AT USA LHD 1.00 1.05 99210-CV000 211027'

vs

b'\xf1\x8b !\x12 ' (2021-12-20)

@sshane sshane merged commit fabec99 into master Feb 7, 2024
27 checks passed
@sshane sshane deleted the log-manufacture-date branch February 7, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific hyundai
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant