-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honda : 2023 Pilot Car Port #30324
Honda : 2023 Pilot Car Port #30324
Conversation
This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity. |
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
6bc5b35
to
8fbe382
Compare
0x33D, LKAS_HUD, on this platform is 8 bytes, not 5 like previous Bosch vehicles In a stock route seeing new data on this signal, SG_ NEW_SIGNAL_1 : 37|3@0+ (1,0) [0|7] "" XXX Edit- looks like the 2022 Civic LKAS_HUD is also 8 bytes, and has this same signal already in the DBC (although it's defined as 2 bits and not 3) |
It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template. |
First Honda that doesn't require the OBD port! 🎉 |
b16a10b
to
ce6637c
Compare
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
We've moved the car interfacing code to our PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you. |
Checklist
selfdrive/car/docs.py
to generate new docsFirst port for a new CAN-FD Honda
DBC Notes:
Using accord DBC, these messages are missing. Will have to check if they are on different ID's now
229 BOSCH_SUPPLEMENTAL_1
232 BRAKE_HOLD
316 GAS_PEDAL
490 VEHICLE_DYNAMICS
545 XXX_16
597 ROUGH_WHEEL_SPEED
892 CRUISE_PARAMS
927 RADAR_HUD
1029 DOOR_STATUS
13274 LKAS_HUD_A
13275 LKAS_HUD_B