Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honda : 2023 Pilot Car Port #30324

Closed
wants to merge 16 commits into from

Conversation

vanillagorillaa
Copy link
Contributor

@vanillagorillaa vanillagorillaa commented Oct 25, 2023

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: f9c43864cf057d05|2024-01-15--23-01-20
  • route with stock system: f9c43864cf057d05|2024-01-13--14-08-31
  • Harness : Bosch C

First port for a new CAN-FD Honda

DBC Notes:
Using accord DBC, these messages are missing. Will have to check if they are on different ID's now
229 BOSCH_SUPPLEMENTAL_1
232 BRAKE_HOLD
316 GAS_PEDAL
490 VEHICLE_DYNAMICS
545 XXX_16
597 ROUGH_WHEEL_SPEED
892 CRUISE_PARAMS
927 RADAR_HUD
1029 DOOR_STATUS
13274 LKAS_HUD_A
13275 LKAS_HUD_B

@github-actions github-actions bot added car vehicle-specific honda labels Oct 25, 2023
Copy link
Contributor

This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions bot added the stale label Dec 15, 2023
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@vanillagorillaa
Copy link
Contributor Author

vanillagorillaa commented Jan 13, 2024

0x33D, LKAS_HUD, on this platform is 8 bytes, not 5 like previous Bosch vehicles

In a stock route seeing new data on this signal, SG_ NEW_SIGNAL_1 : 37|3@0+ (1,0) [0|7] "" XXX

Edit- looks like the 2022 Civic LKAS_HUD is also 8 bytes, and has this same signal already in the DBC (although it's defined as 2 bits and not 3)

Copy link
Contributor

It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template.

@sshane
Copy link
Contributor

sshane commented Jan 26, 2024

First Honda that doesn't require the OBD port! 🎉

Copy link
Contributor

github-actions bot commented Feb 29, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@sshane
Copy link
Contributor

sshane commented Aug 20, 2024

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

@sshane sshane closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants