Honda: Refactor and add CanBus class #31528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template. |
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
sshane
reviewed
Feb 29, 2024
selfdrive/car/honda/interface.py
Outdated
| ret.openpilotLongitudinalControl = True | ||
|
|
||
| ret.pcmCruise = not ret.enableGasInterceptor | ||
|
|
||
| if candidate == CAR.CRV_5G: | ||
| ret.enableBsm = 0x12f8bfa7 in fingerprint[0] | ||
| ret.enableBsm = 0x12f8bfa7 in fingerprint[CAN.pt] |
|
ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @sshane , this adds the CanBus class which will be used for the new CAN FD Honda PR's
#31527 (comment)
#31527
#30324