Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota: use platform config #31607

Merged
merged 39 commits into from
Mar 1, 2024
Merged

Toyota: use platform config #31607

merged 39 commits into from
Mar 1, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Feb 27, 2024

We should think more about grouping, it's nice that you can do that outside the enum creation for stuff like DBCs, common specs, and alike ADAS platforms. Now, you'll have to grep to find common platform details.

Do we want to completely get rid of sets/grouping? This seems like a slight regression for readability.

One change we can make is utilize __post_init__ like we do for the CarInfo, however since everything is in CAR, CAR won't exist yet while initializing the configs. We can use a nonstandard init function and call it later but that doesn't seem that nice

@github-actions github-actions bot added the car vehicle-specific label Feb 27, 2024
@sshane sshane marked this pull request as draft February 27, 2024 11:23
@commaai commaai deleted a comment from github-actions bot Feb 27, 2024
@commaai commaai deleted a comment from github-actions bot Feb 27, 2024
@jnewb1
Copy link
Contributor

jnewb1 commented Feb 27, 2024

One thing I was thinking was using the "or" syntax, like

COROLLA = TSS2_CAR | PlatformConfig(
   ...
)

So you can skip anything set in TSS2_CAR

@sshane sshane marked this pull request as ready for review March 1, 2024 10:08
@commaai commaai deleted a comment from github-actions bot Mar 1, 2024
@sshane sshane merged commit 52ee070 into master Mar 1, 2024
27 of 28 checks passed
@sshane sshane deleted the toyota-pc branch March 1, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants