-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toyota: use platform config #31607
Merged
Toyota: use platform config #31607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
commented
Feb 27, 2024
sshane
commented
Feb 27, 2024
One thing I was thinking was using the "or" syntax, like
So you can skip anything set in TSS2_CAR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should think more about grouping, it's nice that you can do that outside the enum creation for stuff like DBCs, common specs, and alike ADAS platforms. Now, you'll have to grep to find common platform details.
Do we want to completely get rid of sets/grouping? This seems like a slight regression for readability.
One change we can make is utilize
__post_init__
like we do for theCarInfo
, however since everything is inCAR
,CAR
won't exist yet while initializing the configs. We can use a nonstandard init function and call it later but that doesn't seem that nice