Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: improve update_line_data() #32354

Merged
merged 1 commit into from
May 21, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented May 6, 2024

Continuing the optimization of update_line_data() after #25001 by eliminating all memory operations (3 allocations/deallocations and 2 copies).

Think this change is worth it since update_line_data() is the only ui.cc function needing memory operations and is often called in loops.

Copy link
Contributor

github-actions bot commented May 6, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions github-actions bot added the ui label May 6, 2024
@deanlee deanlee force-pushed the ui_improve_update_line_data branch 2 times, most recently from 4d7bbd8 to 51b5123 Compare May 6, 2024 14:08
Copy link
Contributor

This PR has had no activity for 14 days. It will be automatically closed in 3 days if there is no activity.

@github-actions github-actions bot added the stale label May 21, 2024
@adeebshihadeh adeebshihadeh merged commit 0678644 into commaai:master May 21, 2024
75 checks passed
@deanlee deanlee deleted the ui_improve_update_line_data branch May 25, 2024 16:57
@sshane
Copy link
Contributor

sshane commented Jul 19, 2024

@adeebshihadeh this flipped the y coords for the path, causing the coloring to be inverted. Green ahead means red now!

Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
improve update_line_data
old-commit-hash: 0678644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants