Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix flipped experimental path acceleration #33026

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Jul 19, 2024

scene.track_vertices starts at the top right of the path now after #32354, whereas before it was assumed it was bottom left

Here the car was still braking for this intersection but the colors are flipped:

Current:

image

Now:

image

@github-actions github-actions bot added the ui label Jul 19, 2024
Copy link
Contributor

github-actions bot commented Jul 19, 2024

UI Screenshots

@sshane sshane marked this pull request as ready for review July 19, 2024 22:33
@sshane sshane added the bugfix label Jul 19, 2024
@sshane sshane merged commit 0907b30 into master Jul 19, 2024
15 checks passed
@sshane sshane deleted the fix-exp-path-viz branch July 19, 2024 22:39
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
* fix

* clean up

* better comment

* Update selfdrive/ui/qt/onroad/annotated_camera.cc
old-commit-hash: 0907b30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant