-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VW PQ: add fingerprint for new car model #32843
Conversation
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
the route: fails on the check/tests because it isnt in the CI bucket yet. i have it preserved + public in useradmin for the time being. |
@jyoung8607 can you review? I pushed the route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Mk5/6 Golf/Jetta are nearly indistinguishable, which is good given the situation with your particular car and with the weird marketing of the NAR "Jetta" Sportwagen. There are enough ACC-equipped Jettas to make your vehicle supportable.
keeping CarTestRoute Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments on jyoungs comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay to merge. Someday if the port emerges from dashcam, we'll be documenting support for 2015-2018 Jetta only. The radar firmware in this PR is a valid match for those vehicles. We've decided it's not correct to include the earlier NAR "Jetta" Sportwagen in VWCarDocs, so that's been removed.
We've moved the car interfacing code to our PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you. |
FingerPrint
Car
Volkswagen Jetta Sportwagen TDI, 2013 (2011-2014)
Route
578742b26807f756/00000010--41ee3e5bec
Car Model Port:
Checklist
selfdrive/car/docs.py
to generate new docs