Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VW PQ: add fingerprint for new car model #32843

Closed
wants to merge 12 commits into from
Closed

VW PQ: add fingerprint for new car model #32843

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6d5cebf
VW PQ: Add Jetta Sportwagen FP + values
dkiiv Jun 26, 2024
0688879
VW PQ: update chassis_codes value
dkiiv Jun 26, 2024
fd3e2f3
VW PQ: bugfix values.py entry
dkiiv Jun 26, 2024
961a62f
VW PQ: update WMI for JSW TDI
dkiiv Jun 26, 2024
5ba73bc
VW PQ: Add test route, add FP description
dkiiv Jun 26, 2024
8658d03
VW PQ: remove comment for JSW in fingerprints.py, unit test doesn't l…
dkiiv Jun 26, 2024
59ed821
Update selfdrive/car/fingerprints.py
sshane Jun 27, 2024
1028332
VW PQ: remove additional PQ process_replay route
dkiiv Jun 30, 2024
31594bd
update chassis_code
dkiiv Jun 30, 2024
157a58f
VW PQ: update CAR identifier
dkiiv Jun 30, 2024
84f7b2c
Apply suggestions from code review
dkiiv Jun 30, 2024
af99aea
VW PQ: omitt wagon from cardoc, pivot to sedan FP. update orphaned wa…
dkiiv Jun 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions selfdrive/car/tests/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ class CarTestRoute(NamedTuple):
CarTestRoute("58a7d3b707987d65|2021-03-25--17-26-37", VOLKSWAGEN.VOLKSWAGEN_JETTA_MK7),
CarTestRoute("4d134e099430fba2|2021-03-26--00-26-06", VOLKSWAGEN.VOLKSWAGEN_PASSAT_MK8),
CarTestRoute("3cfdec54aa035f3f|2022-07-19--23-45-10", VOLKSWAGEN.VOLKSWAGEN_PASSAT_NMS),
CarTestRoute("578742b26807f756/00000010--41ee3e5bec", VOLKSWAGEN.VOLKSWAGEN_JETTA_SPORTWAGEN),
CarTestRoute("0cd0b7f7e31a3853|2021-11-03--19-30-22", VOLKSWAGEN.VOLKSWAGEN_POLO_MK6),
CarTestRoute("064d1816e448f8eb|2022-09-29--15-32-34", VOLKSWAGEN.VOLKSWAGEN_SHARAN_MK2),
CarTestRoute("7d82b2f3a9115f1f|2021-10-21--15-39-42", VOLKSWAGEN.VOLKSWAGEN_TAOS_MK1),
Expand Down
1 change: 1 addition & 0 deletions selfdrive/car/torque_data/substitute.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ legend = ["LAT_ACCEL_FACTOR", "MAX_LAT_ACCEL_MEASURED", "FRICTION"]
"VOLKSWAGEN_TRANSPORTER_T61" = "VOLKSWAGEN_TIGUAN_MK2"
"AUDI_Q2_MK1" = "VOLKSWAGEN_TIGUAN_MK2"
"VOLKSWAGEN_TAOS_MK1" = "VOLKSWAGEN_TIGUAN_MK2"
"VOLKSWAGEN_JETTA_SPORTWAGEN" = "VOLKSWAGEN_PASSAT_NMS"
"VOLKSWAGEN_POLO_MK6" = "VOLKSWAGEN_GOLF_MK7"
"SEAT_ATECA_MK1" = "VOLKSWAGEN_GOLF_MK7"

Expand Down
8 changes: 8 additions & 0 deletions selfdrive/car/volkswagen/fingerprints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,14 @@
b'\xf1\x877N0907572C \xf1\x890211\xf1\x82\x0152',
],
},
CAR.VOLKSWAGEN_JETTA_SPORTWAGEN: {
(Ecu.srs, 0x715, None): [
b'\xf1\x875C0959655M \xf1\x890726\xf1\x82\t00NB1108--------24',
],
(Ecu.fwdRadar, 0x757, None): [
b'\xf1\x877N0907572C \xf1\x890211\xf1\x82\x0151',
],
},
CAR.VOLKSWAGEN_POLO_MK6: {
(Ecu.engine, 0x7e0, None): [
b'\xf1\x8704C906025H \xf1\x895177',
Expand Down
6 changes: 6 additions & 0 deletions selfdrive/car/volkswagen/values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,12 @@ class CAR(Platforms):
chassis_codes={"A3"},
wmis={WMI.VOLKSWAGEN_USA_CAR},
)
VOLKSWAGEN_JETTA_MK6 = VolkswagenPQPlatformConfig(
[VWCarDocs("Volkswagen Jetta Sportwagen TDI 2011-2014")],
dkiiv marked this conversation as resolved.
Show resolved Hide resolved
VolkswagenCarSpecs(mass=1518, wheelbase=2.62, minSteerSpeed=50 * CV.KPH_TO_MS, minEnableSpeed=20 * CV.KPH_TO_MS),
dkiiv marked this conversation as resolved.
Show resolved Hide resolved
chassis_codes={"5K", "AJ"},
wmis={WMI.VOLKSWAGEN_MEXICO_CAR},
)
VOLKSWAGEN_POLO_MK6 = VolkswagenMQBPlatformConfig(
[
VWCarDocs("Volkswagen Polo 2018-23", footnotes=[Footnote.VW_MQB_A0]),
Expand Down
Loading