add longitudinal maneuvers #33527
Merged
add longitudinal maneuvers #33527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
127
to
128
| if maneuver is None: | ||
| print('We are done!') |
There was a problem hiding this comment.
I think wrapping around is better than no maneuvers
There was a problem hiding this comment.
Without any alert it may be easy to miss that the report is done
|
@adeebshihadeh Anything else you think the first iteration needs? |
13 tasks
cydia2020
pushed a commit
to cydia2020/dodgypilot
that referenced
this pull request
Sep 13, 2024
* add longitudinal profiles * stash * unfortunately even longitudinalPlan causes circle * add to process config * reach target speed smoothly * stash * works * clean up * debug alert * rename * fix * better text * toggle via exp button * try coming to a stop better, smoother target reaching * closer to target * revert controlsd migration * add description to alert * generate report from local logs * hide bad maneuvers * pdflike * Revert "pdflike" This reverts commit 6d4af1b. * try this * use alert manager * fix that check * wat * Revert "wat" This reverts commit 93d0d27. * some clean up * rm * cleanup * move * fix test * more fix * clean up * fix that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from opendbc: https://github.com/commaai/opendbc/blob/ef7102a8ae2334d77ff4b0be512c073e81b01d18/examples/longitudinal-profiles.py
LongitudinalManeuverMode