-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steer Rate consideration for Lateral Control #435
Conversation
Here is a video from a test with very low values for steerRateCost and steerActuatorDelay. |
After feedback from several testers (Honda's and Toyota's), it was clear that the previous logic was better in cases that the steer rate was low OR the steer error was low. My last commit seems like the best of both. |
This PR has become rather outdated, since I've continued making progress using various strategies. However, I finally made a large break-through yesterday, which results in virtually "ideal" steering response. It needs testing on other vehicles, and the code needs to be refactored (hopefully with your input), so I'm not sure whether this PR should be closed, or not. Please advise. Also, here is a video of the results, which also explains how the steering system can be treated as a resonant circuit by making the PID inputs more reactive, inductive, and resistive. This shows how quickly and smoothly the steering recovers after manual disturbance of lane position. |
As I said, it's not "PR ready" yet, but you can view the logic in this branch. |
I'm closing this PR since the enhancements have been ongoing. I will create a new PR (or multiple separate PR's) for the following soon:
These enhancements exist in the branch below, and have been tested with success on Honda's, Toyota's, and Tesla's. https://github.com/Gernby/openpilot/tree/Feed-Forward-Resonant |
* Fix orientation designations in harness.h * Fix orientation designations in black.h * Fix orientation designations in uno.h * Fix typo
rockettttt
This fix adds steering rate consideration to latcontrol.py, to reduce error (noise) in the torque calculation.
This has the following benefits: