Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always send loud alert when cruise disables in specific braking scenario #468

Closed
wants to merge 4 commits into from
Closed

Always send loud alert when cruise disables in specific braking scenario #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
654abc4
Always send loud alert when cruise disables
NeonGalaxy75 Dec 16, 2018
4bdeffe
Revert "Always send loud alert when cruise disables"
NeonGalaxy75 Dec 19, 2018
677d22a
Louder alert when OP disengages under cruise min speed
NeonGalaxy75 Dec 19, 2018
403c3ab
Call speedTooLowNoEntry if OP not engaged
NeonGalaxy75 Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion selfdrive/car/honda/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ def update(self, c):
events.append(create_event('parkBrake', [ET.NO_ENTRY, ET.USER_DISABLE]))

if self.CP.enableCruise and ret.vEgo < self.CP.minEnableSpeed:
events.append(create_event('speedTooLow', [ET.NO_ENTRY]))
events.append(create_event('speedTooLowNoEntry', [ET.NO_ENTRY]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you want to keep speedTooLow (the NoEntry is added in controlsd)


# disable on pedals rising edge or when brake is pressed and speed isn't zero
if (ret.gasPressed and not self.gas_pressed_prev) or \
Expand Down
2 changes: 1 addition & 1 deletion selfdrive/controls/lib/alerts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ def __gt__(self, alert2):
"openpilot Canceled",
"Speed too low",
AlertStatus.normal, AlertSize.mid,
Priority.HIGH, VisualAlert.none, AudibleAlert.chimeDisengage, .4, 2., 3.),
Priority.HIGH, VisualAlert.steerRequired, AudibleAlert.chimeWarningRepeat, 1., 3., 4.),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm... but an audible alert (the same used for normal disengagement) is already issued. Your change just makes it louder, which I think is too annoying.
Sorry, I was under the impression that before your change OP wasn't issuing any audible alert.


Alert(
"invalidGiraffeHonda",
Expand Down