Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always send loud alert when cruise disables in specific braking scenario #468

Closed
wants to merge 4 commits into from
Closed

Commits on Dec 16, 2018

  1. Always send loud alert when cruise disables

    For users without the pedal there are sometimes instances where
    1.  the car brakes because lead car is slowing, 
    2.  the car falls below the minimum cruise threshold and cruise disables
    3.  the lead car pulls away
    4.  car is now below cruise so can't accelerate, the non-loud alert is displayed and OP is disabled - the user doesn't notice
    5.  the lead car brakes
    6.  the user is caught flat footed because they weren't aware that step 4 happened because couldn't hear / see the subtle alert that OP was disabled
    
    This is a safety concern as it happened to me a few times before I got my pedal.  Sending the loud alert mitigates this risk.
    NeonGalaxy75 authored Dec 16, 2018
    Configuration menu
    Copy the full SHA
    654abc4 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2018

  1. Revert "Always send loud alert when cruise disables"

    This reverts commit 654abc4.
    NeonGalaxy75 committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    4bdeffe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    677d22a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    403c3ab View commit details
    Browse the repository at this point in the history