Fixes for various merge and refactoring fallout, typo fixes. #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbiasini
reviewed
Nov 13, 2019
rbiasini
reviewed
Nov 13, 2019
jyoung8607
commented
Nov 13, 2019
jordanmkoncz
added a commit
to jordanmkoncz/openpilot
that referenced
this pull request
Nov 15, 2019
dragonpilot
pushed a commit
to dragonpilot-community/dragonpilot
that referenced
this pull request
Apr 7, 2020
…#878) * Fixes for various merge and refactoring fallout, typo fixes. * Tab->Spaces
kegman
added a commit
to kegman/openpilot
that referenced
this pull request
Feb 20, 2021
* Decrease build time for dbc files * Fix fan control when not plugged into panda * Fix unicode bug in DoUninstall reading * Make visiond compile on pc (commaai#874) * Make DBC preprocessing deterministic * Add fingerprint (commaai#875) * Fixes for various merge and refactoring fallout, typo fixes. (commaai#878) * Fixes for various merge and refactoring fallout, typo fixes. * Tab->Spaces * Update driving model (commaai#880) * Fix typo (commaai#891) * Reimplemented core changes on 0.6.6 * updated readme and dbc * Added 2017 Bolt fingerprint * updated readme * this should have never worked... * I guess I was wrong about that * Safe passthrough (#9) * stuff * experimenting with timer 12 interval * experimetning with timers * more debugging * more timer stuff * timer works - adjusting period * first bold attempt * booboo * more whoopsies * ugh * attempting cleaner impl * fixes * more fixing * more fixes * more fixes * workies * Added lkas hook default * Fixed missing parens * Boldness - enabling the lkas send * Fixed activation of op lkas * tried to do this the right way... * very broken * debugging * more attempts to fix * debugging * grr * disabling timer * sanity check * switching to timer 5 * little cleanup * debugging * timer 5 is special... * lets try timer 6 * debugging * tim7 * whoops * debugging * just the comment * ddd * maybe found bug.. * debuggery * added lkas to all models * bold implementation * gotta return that value... * Now we should get some data * removing hardcoded null * wrong bus no? * bloop * Lysdexia... * whoops * better debug * debugs * better debug; maybe fix rc * woops * more whoops * trying some fixery * I did the pointers wrong... * more pointer issues * ugh * trying volatile * more vol * more volatiles * more volatile * removing volatiles from structs * vol again * maybe a fix? * maybe don't need on op * rc was wrong * my bits are weak * shifty * idk * I suck at bitwise everything * only send once * bit what? * gah! * mathys lol * I'm not smart enough for this * bits are stupid * cleanup, should fix all faults * lkas->pump, no camera mode * timer started in safety init, configurable interva * note about init * something really didn't work... * maybe not littleendian? * improved safety, can#, etc * casing issue * removed hook, cleanup names, etc * moved to safety.h * trying to fix errors * pointers... * more pointer confusion * yet more pointers... * null typo * pump disabled on no_output * added debug comments * abstracting * missed a couple * bugs * more bugs * made buffer volatile * unvolatile casting * bug * casting syntax... * debug message updates * if ordering issue * bugfix, cleanup * add pedal_pressed * missing or 1 on stock RIR * more volatile * very strange behavior * bug; reduced volatility * casting * added 2012 prius fingerprint * Hardcoded ignition on... * commented out some blocking events * removed hardcoded ign * rolling back all prius junk * added equinox * hardcode escalade * disabling forwarding * enable radar; increase steer_max * removed radar * radar back; more power!! * torque to 550 Co-authored-by: Riccardo <riccardo.biasini@gmail.com> Co-authored-by: Willem Melching <willem.melching@gmail.com> Co-authored-by: Alex Wang <36569033@qq.com> Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com> Co-authored-by: Shane Smiskol <shane@smiskol.com> Co-authored-by: jshuler <jshuler@gmail.com>
steerapi
pushed a commit
to steerapi/openpilot
that referenced
this pull request
Mar 28, 2022
Sync Branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup
This pull request performs some minor cleanup of things lost-in-translation during the merge of Volkswagen MQB support and the simultaneous DBC code refactor.
can/common.pxd: Add VOLKSWAGEN_CHECKSUM and VOLKSWAGEN_COUNTER for consistency with the other copies of the SignalType enum, although I can't find any ill effect from them being missing here.
can/dbc_template.cc: Correct an indentation issue that crept in IDK when.
can/parser.cc: Remove incorrect debug printf. Restore "0x" prefixing before debug error printfs, to clarify a hex rather than decimal address is being printed, and fix another typo.
car/volkswagen/carcontroller.py: Make use of an existing, named param value rather than an undocumented constant.
car/volkswagen/values.py: Discard objects that were only used for camera detection, which is not required on VW MQB and got removed from interface.py before upstream.
Testing
Passes Docker testing here.