Updated RAV4 Hybrid TSS2 Port #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geohot
reviewed
Jan 18, 2020
|
@pd0wm Do we have an automated check that the fingerprints don't conflict? |
Yes. We just need to add it to the list of CI routes. |
|
Approved once CI is back up and it's it there. |
|
I'm working getting all our route sync scripts back up and running. Will update this PR once done. |
|
You. Can. Do. It!!! |
|
Fingerprint now conflicts after merging #965 |
|
Uploaded this route to CI: "7e34a988419b5307|2019-12-18--19-13-30": {
'carFingerprint': TOYOTA.RAV4H_TSS2,
'enableCamera': True,
},Can you add that to the list of test_car_models and rebase with master? |
|
About the Israeli Corolla fingerprint, let's remove it in this PR so CI passes. I'll try to get FW query fingerprinting working asap, so then this should not be a problem anymore. |
From wocsor's PR commaai#740 cleanup fingerprint 2020 rav4 hybrid confirmed working
Adds additional messages for Limited trim. XSE and XLE still contained within this longer Limited fingerprint.
Adds 913:8 value from discord user RDuke
This reverts commit f1d6f68.
illumiN8i
force-pushed
the
PR-RAV4-Hybrid-TSS2
branch
from
87f099d
to
d3d07a4
Compare
|
Done |
otaku
pushed a commit
to otaku/openpilot
that referenced
this pull request
Jan 24, 2020
* merge wocsor RAV4_HYBRID_TSS2 branch From wocsor's PR commaai#740 cleanup fingerprint 2020 rav4 hybrid confirmed working * 2019 RAV4 Hybrid Limited Adds additional messages for Limited trim. XSE and XLE still contained within this longer Limited fingerprint. * Support Swiss 2019 RAV4 Hybrid XLE Adds 913:8 value from discord user RDuke * Separated RAV4 ICE and Hybrid * Add route to test_car_models.py * Revert "Toyota Corolla Hatchback Hybrid 2019 Excite (Israel)" This reverts commit f1d6f68.
JMPZ11
added a commit
to opgm/openpilot
that referenced
this pull request
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Car support
This pull requests adds support for Toyota - RAV4 Hybrid - 2019, 2020 - XSE, XLE, Limited.
This is an updated version of PR #740
This is an explorer link to a drive with the stock system enabled on Limited trim from discord user bikamake: https://my.comma.ai/cabana/?route=37a1ee26e697b2f5%7C2020-01-02--17-02-35&exp=1609539781&sig=27Sw59xBx4gNpEZVjYJvJcCb1duIyL8q6HZwBtMn5r0%3D&max=8&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F37a1ee26e697b2f5%2F6cda466a54bfd3d23b993080d8d0e04e_2020-01-02--17-02-35
This is an explorer link to a drive with openpilot system enabled on XLE from discord user david (.ghost): https://my.comma.ai/cabana/?route=7e34a988419b5307%7C2019-12-18--19-13-30&exp=1608234361&sig=ijJbjI0Hohe5lXLsCMZdjhIkgC0ZWWejJFsHjTxmssI%3D&max=4&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F7e34a988419b5307%2F264bd7952ade031f4318a13b4de87227_2019-12-18--19-13-30
This is an explorer link to a drive with the stock system enabled on XSE trim from discord user sideplugmike:
Stock drive: https://my.comma.ai/cabana/?route=689f254b15632b32%7C2019-12-18--17-16-45&exp=1608309192&sig=ab%2FQM3baV9GMWf00M6Ov5kkPl%2BkzkR%2BnraMU14dANtM%3D&max=21&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F689f254b15632b32%2Ff1eb650f3f355dd869ee9e3c345373e5_2019-12-18--17-16-45
Stock drive from discord user RDuke to confirm the addition of 913:8 to support Swiss 2019 RAV4 Hybrid XLE: https://my.comma.ai/cabana/?route=192a598e34926b1e%7C2020-01-11--08-19-10&exp=1610294691&sig=245p84BFx9ym4yvcbPWaY8Pqnw9EtBKY4g9aNCHViUw%3D&max=2&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F192a598e34926b1e%2Fb39e89b8bef01a01d0de71122fb613ca_2020-01-11--08-19-10