-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyundai CAN Longitudinal: Enable for Camera SCC cars #1107
Open
sunnyhaibin
wants to merge
11
commits into
commaai:master
Choose a base branch
from
sunnypilot:camera-scc-long
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you write a test case for these in tests/safety/test_hyundai.py? |
I could attempt it in the next coming days. |
sunnyhaibin
force-pushed
the
camera-scc-long
branch
from
August 15, 2023 05:21
cd0400e
to
d78cae7
Compare
sunnyhaibin
force-pushed
the
camera-scc-long
branch
from
September 25, 2024 06:15
4dcde30
to
a26093a
Compare
Unite test updated and all passed. |
sunnyhaibin
changed the title
Hyundai: Longitudinal support for CAN-based Camera SCC cars
Hyundai CAN Longitudinal: Enable for Camera SCC cars
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openpilot longitudinal control support for CAN-based HKG cars that have the following messages send from the car on bus 2:
SCC11
SCC12
SCC13
SCC14
FCA11
FCA12
Currently with 2022 Hyundai Kona EV, without radar disable. As the messages send from the car on bus 2, we block the messages and send our own longitudinal commands to bus 0.
FCA11
andFCA12
do stock FCW and AEB, and are forwarded from the LKAS camera to the car.Prerequisite of
Related
Thanks to community Kona EV 2022 owner Zack1010OP.