Improve regex for Entry Point Uri Path to accept at least 2 characters #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 000087c The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ddouglasz
commented
May 10, 2022
| @@ -30,7 +30,7 @@ | |||
| "oneOf": [ | |||
| { | |||
| "type": "string", | |||
| "pattern": "^[^\\-_]([0-9a-z]|[\\-_](?![\\-_])){2,64}[^\\-_]$" | |||
| "pattern": "^[^\\-_#]([0-9a-z]|[\\-_](?![\\-_])){0,62}[^\\-_#]$" | |||
There was a problem hiding this comment.
I assume that since # is kind of like a special url character, maybe we want to check in the character class [^-_#] beginning and end to be sure the entryPathUriPath does not start or end with it too.
Any thoughts on this?
There was a problem hiding this comment.
Good idea, thanks for noticing.
Let's add it to the regex as you suggested, thanks!
kark
approved these changes
May 11, 2022
tdeekens
approved these changes
May 11, 2022
Rhotimee
approved these changes
May 11, 2022
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve regex for Entry Path Url to accept at least 2 alphanumeric characters.
Currently, the regex to validate the entryPointUriPath seems to prevent at least 2 characters. Find more information here