-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve regex for Entry Point Uri Path to accept at least 2 characters #2601
Conversation
🦋 Changeset detectedLatest commit: 000087c The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -30,7 +30,7 @@ | |||
"oneOf": [ | |||
{ | |||
"type": "string", | |||
"pattern": "^[^\\-_]([0-9a-z]|[\\-_](?![\\-_])){2,64}[^\\-_]$" | |||
"pattern": "^[^\\-_#]([0-9a-z]|[\\-_](?![\\-_])){0,62}[^\\-_#]$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that since #
is kind of like a special url character, maybe we want to check in the character class [^-_#]
beginning and end to be sure the entryPathUriPath does not start or end with it too.
Any thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thanks for noticing.
Let's add it to the regex as you suggested, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Improve regex for Entry Path Url to accept at least 2 alphanumeric characters.
Currently, the regex to validate the entryPointUriPath seems to prevent at least 2 characters. Find more information here