Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve regex for Entry Point Uri Path to accept at least 2 characters #2601

Merged
merged 2 commits into from
May 11, 2022
Merged

Improve regex for Entry Point Uri Path to accept at least 2 characters #2601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
303a3c7
feat(validate entryPointUriPath): entyrypoint uri path should accept …
ddouglasz May 10, 2022
000087c
feat(validate entryPointUriPath): check for special character #
ddouglasz May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/polite-jars-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@commercetools-frontend/application-config': patch
---

validating entry point uri path should allow two characters
2 changes: 1 addition & 1 deletion packages/application-config/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"oneOf": [
{
"type": "string",
"pattern": "^[^\\-_]([0-9a-z]|[\\-_](?![\\-_])){2,64}[^\\-_]$"
"pattern": "^[^\\-_#]([0-9a-z]|[\\-_](?![\\-_])){0,62}[^\\-_#]$"
Copy link
Contributor Author

@ddouglasz ddouglasz May 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that since # is kind of like a special url character, maybe we want to check in the character class [^-_#] beginning and end to be sure the entryPathUriPath does not start or end with it too.
Any thoughts on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks for noticing.

Let's add it to the regex as you suggested, thanks!

},
{
"$ref": "#/definitions/envVariablePlaceholder"
Expand Down