-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Hpack #530 Make use of prettier Hpack error messages #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpilgrem
added a commit
to commercialhaskell/stack
that referenced
this pull request
Dec 7, 2022
For the context to this pull request, see see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). See also [Pantry PR #74](commercialhaskell/pantry#74) (on which this PR builds).
2 tasks
mpilgrem
force-pushed
the
fix-hpack530
branch
3 times, most recently
from
December 7, 2022 20:59
fda261f
to
6c90ce3
Compare
mpilgrem
added a commit
to commercialhaskell/stack
that referenced
this pull request
Dec 7, 2022
For the context to this pull request, see see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). See also [Pantry PR #74](commercialhaskell/pantry#74) (on which this PR builds).
mpilgrem
force-pushed
the
fix-hpack530
branch
from
December 11, 2022 15:48
6c90ce3
to
badcdb8
Compare
@mpilgrem I think the MacOS build error is |
sol
reviewed
Dec 11, 2022
Ok, so apparently it was the cache. I'm still not sure how exactly. But some observations:
|
mpilgrem
force-pushed
the
fix-hpack530
branch
3 times, most recently
from
December 11, 2022 20:03
fbe8597
to
ec2048a
Compare
mpilgrem
added a commit
to commercialhaskell/stack
that referenced
this pull request
Dec 11, 2022
For the context to this pull request, see see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). See also [Pantry PR #74](commercialhaskell/pantry#74) (on which this PR builds).
mpilgrem
force-pushed
the
fix-hpack530
branch
2 times, most recently
from
December 12, 2022 13:44
4334e28
to
94d68b5
Compare
Prettier Hpack error messages are enabled by hpack-0.35.1. For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). Also conforms form of messages of Errors [S-305] and [S-720] and the naming of arguments (`err`) in the `PantryException` instance of `Display`. Also bumps from lts-20.0 to lts-20.4 (most recent GHC 9.2.5).
mpilgrem
force-pushed
the
fix-hpack530
branch
from
December 12, 2022 13:52
94d68b5
to
dd37355
Compare
mpilgrem
changed the title
Fix Hpack #530
Fix Hpack #530 Make use of prettier Hpack error messages
Dec 12, 2022
Example output of Pantry (via Stack): Duff
Duff
|
mpilgrem
added a commit
to commercialhaskell/stack
that referenced
this pull request
Dec 15, 2022
For the context to this pull request, see see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). See also [Pantry PR #74](commercialhaskell/pantry#74) (on which this PR builds).
mpilgrem
added a commit
to commercialhaskell/stack
that referenced
this pull request
Dec 16, 2022
For the context to this pull request, see see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). See also [Pantry PR #74](commercialhaskell/pantry#74) (on which this PR builds).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the context to this pull request see Hpack issue #530, the Hpack PR #531 and the alternative Hpack PR #535 (on which this PR builds).
This PR is draft until such time as there is a released version of Hpack on which it relies.