Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HpackError type #535

Merged
merged 1 commit into from
Dec 11, 2022
Merged

Add HpackError type #535

merged 1 commit into from
Dec 11, 2022

Conversation

sol
Copy link
Owner

@sol sol commented Dec 5, 2022

No description provided.

@sol sol force-pushed the dev branch 5 times, most recently from be187b1 to ec714b3 Compare December 5, 2022 12:27
@sol sol changed the base branch from main to refactor December 5, 2022 12:27
@sol sol changed the base branch from refactor to main December 5, 2022 13:11
@sol sol force-pushed the dev branch 4 times, most recently from 34ea8f8 to 1ecc415 Compare December 5, 2022 19:22
@sol sol mentioned this pull request Dec 5, 2022
Closed
mpilgrem added a commit to commercialhaskell/pantry that referenced this pull request Dec 7, 2022
@mpilgrem
Fix Hpack #530
155c16c 
For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds).
@mpilgrem mpilgrem mentioned this pull request Dec 7, 2022
Merged
mpilgrem added a commit to commercialhaskell/stack that referenced this pull request Dec 7, 2022
@mpilgrem
Fix Hpack #530
36af1bf 
For the context to this pull request, see see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). See also [Pantry PR #74](commercialhaskell/pantry#74) (on which this PR builds).
@mpilgrem mpilgrem mentioned this pull request Dec 7, 2022
Merged
2 tasks
mpilgrem added a commit to commercialhaskell/pantry that referenced this pull request Dec 7, 2022
@mpilgrem
Fix Hpack #530
24aba00 
For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds).
mpilgrem added a commit to commercialhaskell/pantry that referenced this pull request Dec 7, 2022
@mpilgrem
Fix Hpack #530
fda261f 
For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds).
mpilgrem added a commit to commercialhaskell/pantry that referenced this pull request Dec 7, 2022
@mpilgrem
Fix Hpack #530
6c90ce3 
For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds).
mpilgrem added a commit to commercialhaskell/stack that referenced this pull request Dec 7, 2022
@mpilgrem
Fix Hpack #530
624d967 
For the context to this pull request, see see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). See also [Pantry PR #74](commercialhaskell/pantry#74) (on which this PR builds).
@sol sol force-pushed the dev branch 3 times, most recently from 69c6f30 to 4cc002c Compare December 11, 2022 13:43
@sol sol marked this pull request as ready for review December 11, 2022 14:03
@sol sol changed the title Add HpackError type (alternative approach) Add HpackError type Dec 11, 2022
mpilgrem added a commit to commercialhaskell/pantry that referenced this pull request Dec 11, 2022
@mpilgrem
Fix Hpack #530
badcdb8 
For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds).
mpilgrem added a commit to commercialhaskell/pantry that referenced this pull request Dec 11, 2022
@mpilgrem
Fix Hpack #530
91a844e 
For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds).
mpilgrem added a commit to commercialhaskell/pantry that referenced this pull request Dec 11, 2022
@mpilgrem
Fix Hpack #530
fbe8597 
For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds).
mpilgrem added a commit to commercialhaskell/pantry that referenced this pull request Dec 11, 2022
@mpilgrem
Fix Hpack #530
ec2048a 
For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds).
mpilgrem added a commit to commercialhaskell/stack that referenced this pull request Dec 11, 2022
@mpilgrem
Fix Hpack #530
baf80f6 
For the context to this pull request, see see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). See also [Pantry PR #74](commercialhaskell/pantry#74) (on which this PR builds).
@sol sol merged commit be9b7fa into main Dec 11, 2022
@sol sol deleted the dev branch December 11, 2022 22:55
@sol sol mentioned this pull request Dec 11, 2022
Closed
mpilgrem added a commit to commercialhaskell/pantry that referenced this pull request Dec 12, 2022
@mpilgrem
Fix Hpack #530 Make use of prettier Hpack error messages
4334e28 
Prettier Hpack error messages are enabled by hpack-0.35.1.

For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds).

Also bumps from lts-20.0 to lts-20.4 (most recent GHC 9.2.5).
mpilgrem added a commit to commercialhaskell/pantry that referenced this pull request Dec 12, 2022
@mpilgrem
Fix Hpack #530 Make use of prettier Hpack error messages
94d68b5 
Prettier Hpack error messages are enabled by hpack-0.35.1.

For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds).

Also conforms form of messages of Errors [S-305] and [S-720].

Also bumps from lts-20.0 to lts-20.4 (most recent GHC 9.2.5).
mpilgrem added a commit to commercialhaskell/pantry that referenced this pull request Dec 12, 2022
@mpilgrem
Fix Hpack #530 Make use of prettier Hpack error messages
dd37355 
Prettier Hpack error messages are enabled by hpack-0.35.1.

For the context to this pull request see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds).

Also conforms form of messages of Errors [S-305] and [S-720] and the naming of arguments (`err`) in the `PantryException` instance of `Display`.

Also bumps from lts-20.0 to lts-20.4 (most recent GHC 9.2.5).
mpilgrem added a commit to commercialhaskell/stack that referenced this pull request Dec 15, 2022
@mpilgrem
Fix Hpack #530
0b9057c 
For the context to this pull request, see see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). See also [Pantry PR #74](commercialhaskell/pantry#74) (on which this PR builds).
mpilgrem added a commit to commercialhaskell/stack that referenced this pull request Dec 16, 2022
@mpilgrem
Fix Hpack #530
31128fa 
For the context to this pull request, see see [Hpack issue #530](sol/hpack#530), the [Hpack PR #531](sol/hpack#531) and the alternative [Hpack PR #535](sol/hpack#535) (on which this PR builds). See also [Pantry PR #74](commercialhaskell/pantry#74) (on which this PR builds).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sol