Fix #5713 Don't assume unified coverage report redundant if only one *.tix file #5731
Conversation
…nly one *.tix file Currently, `Stack.Coverage.generateHpcUnifiedReport` assumes that a unified coverage report will be redundant if there is only one `*.tix` file. However, that is not necessarily the case. For example, one package may test the library of another package that does not test its own library. As an interim solution, this proposed pull request suggests that a unified report should always be produced if there is one or more `*.tix` files, even if it may be redundant in some circumstances. A more complex solution would be to have a more complex test that determines whether a unified report would be truely redundant if there is only one `*.tix` file.
|
I just checked and this does indeed solve my problem in #5713 . 🎉 |
|
@mpilgrem Do we need anything for this to be merged? |
|
As I have identified in other recent pull requests, I am new to being an outside collaborator, in general and on |
|
I have commit rights, but I'm not sure it'd be proper for me to merge this either... |
|
I don't see any complaints, this seems very sensible, and I've tried it out, so I'll go ahead and merge. |
Currently,
Stack.Coverage.generateHpcUnifiedReportassumes that a unified coverage report will be redundant if there is only one*.tixfile. However, that is not necessarily the case. For example, one package may test the library of another package that does not test its own library.As an interim solution, this proposed pull request suggests that a unified report should always be produced if there is one or more
*.tixfiles, even if it may be redundant in some circumstances.A more complex solution would be to have a more complex test that determines whether a unified report would be truely redundant if there is only one
*.tixfile.Please also shortly describe how you tested your change. Bonus points for added tests! Tested by building, and using,
stack.