Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5713 Don't assume unified coverage report redundant if only one *.tix file #5731

Merged
merged 1 commit into from
May 4, 2022
Merged

Fix #5713 Don't assume unified coverage report redundant if only one *.tix file #5731

merged 1 commit into from
May 4, 2022

Commits on May 2, 2022

  1. Fix commercialhaskell#5713 Don't assume unified report redundant if o… 

    …nly one *.tix file

Currently, `Stack.Coverage.generateHpcUnifiedReport` assumes that a unified coverage report will be redundant if there is only one `*.tix` file. However, that is not necessarily the case. For example, one package may test the library of another package that does not test its own library.

As an interim solution, this proposed pull request suggests that a unified report should always be produced if there is one or more `*.tix` files, even if it may be redundant in some circumstances.

A more complex solution would be to have a more complex test that determines whether a unified report would be truely redundant if there is only one `*.tix` file.
    @mpilgrem
    mpilgrem committed May 2, 2022
    Configuration menu
    Copy the full SHA
    b06a523 View commit details
    Browse the repository at this point in the history