Fix custom picker not consider rotated image #5569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[The image path of rotated image is not save like nornal image. so imageview cannot load rotated image check whether the image path is file uri then add imagerequest to load the image] [fixed: thumbnail not visible when upload rotated image]
…custom picker [Rotated image is now saved in directory where capture image is saved and image is inserted to media store] [fixed: Rotated uploaded pic not considered uploaded by custom picker]
|
Testing this pull request now, I am geting tthis error: screen-20240220-232741.mp4Any idea why? 🙂 |
|
I will test again and get back to u |
[some android sdk that is greater than 28 unable to add image to media store database] [fixed: commons-app#5384]
|
I have fixed the bug the phone am using is android sdk 28, that is why i use emulator to test bugs.mp4 |
nicolas-raoul
requested changes
Feb 21, 2024
neeldoshii
suggested changes
Mar 25, 2024
| @@ -3,11 +3,17 @@ package fr.free.nrw.commons.edit | |||
| import android.animation.Animator | |||
| import android.animation.Animator.AnimatorListener | |||
| import android.animation.ValueAnimator | |||
| import android.content.ContentResolver | |||
| import android.content.ContentValues | |||
| import android.content.Intent | |||
| import android.graphics.BitmapFactory | |||
| import android.graphics.Matrix | |||
| import android.media.ExifInterface | |||
There was a problem hiding this comment.
Looks good, few nitpicks rest good.
- import android.media.ExifInterface
+ import androidx.exifinterface.media.ExifInterfaceAvoid using android.media.ExifInterface; use androidx.exifinterface.media.ExifInterface instead
This has been deprecated due to the security issue. Its better to replace it.check this
Also IDE recommends : Avoid using android.media.ExifInterface; use androidx.exifinterface.media.ExifInterface instead
nicolas-raoul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5384
change where rotated image is saved and add image to media store
Tests performed (required)
Tested BetaDebug on Tecno Spark Air with API level 38.