Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds skip-dirs to trivy image scan #116

Merged
merged 1 commit into from
Dec 13, 2023
Merged

chore: adds skip-dirs to trivy image scan #116

merged 1 commit into from
Dec 13, 2023

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented Dec 12, 2023 •
edited
Loading

Description

Metadata pulled into the virtual environment during a fresh image build for
dependencies contain false positives/examples in docs that are flagged.
Skip Python metadata in directories that are not maintained in this project.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432
chore: adds skip-dirs to trivy image scan
01854b8 
Metadata pulled into the virtual environment for
dependencies contain false positives/examples. Skip Python metadata in directories
that are not maintained in this project.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 mentioned this pull request Dec 13, 2023
Merged
10 tasks
beatrizmcouto
beatrizmcouto approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed during paired code review Dec 13

@jpower432 jpower432 merged commit 3c68011 into complytime:main Dec 13, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrizmcouto beatrizmcouto beatrizmcouto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @beatrizmcouto