Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds image signing with cosign to publish.yml #82

Merged
merged 3 commits into from
Dec 13, 2023
Merged

chore: adds image signing with cosign to publish.yml #82

merged 3 commits into from
Dec 13, 2023

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented Nov 20, 2023 •
edited
Loading

Description

Adds image signing with cosign to the image publishing workflow.

Stacked with #116 to resolve issues with image published.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 marked this pull request as ready for review November 21, 2023 19:34
@jpower432 jpower432 added the ci CI Related work label Dec 4, 2023
@jpower432 jpower432 marked this pull request as draft December 6, 2023 22:33
@jpower432 jpower432 force-pushed the PSCE-266 branch 2 times, most recently from 71aaded to 73085f1 Compare December 6, 2023 22:55
@jpower432 jpower432 marked this pull request as ready for review December 6, 2023 23:12
@jpower432 jpower432 added github_actions Pull requests that update GitHub Actions code and removed ci CI Related work labels Dec 8, 2023
@jpower432 jpower432 marked this pull request as draft December 13, 2023 14:45
@jpower432
Copy link
Contributor Author

Converting to draft to resolve conflicts

@jpower432 jpower432 marked this pull request as ready for review December 13, 2023 16:06
@jpower432
chore: adds image signing with cosign to publish.yml
359640a 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
chore: add ignore line for KICS false positive
607ae61 
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
fix: update the verification steps to add identity regexp and issuer
61e2f8c 
Adds a regular expression so a consumer can verify that image was published
from the expected repository.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
beatrizmcouto
beatrizmcouto approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed during paired code review on Dec 13

@jpower432 jpower432 merged commit f6f7035 into complytime:main Dec 13, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrizmcouto beatrizmcouto beatrizmcouto approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @beatrizmcouto