Don't use browser alias for component-indexof dependency. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm short of the addition to |
|
Ah sry, wasn't aware. I'll remove that. |
This way, `component-classes` won't break node code/tests when imported.
ockham
force-pushed
the
dont-user-indexof-browser-alias
branch
from
ac37042 to
2373559
Compare
|
Amended the commit. |
stephenmathieson
added a commit
that referenced
this pull request
Feb 29, 2016
Don't use browser alias for component-indexof dependency.
|
cool, thanks dude! |
|
https://www.npmjs.com/package/component-classes still shows 1.2.4 as the latest release. Manual intervention required? :-D |
|
sorry, forgot to npm publish. should be there now =) |
|
@ronkorving Apologies -- filed a fix at #29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way,
component-classeswon't break node code/tests when imported.You might want to change the release date in
History.md/cc @TooTallNate