Don't use browser alias for component-each dependency #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please point-release after merging! |
ockham
force-pushed
the
dont-user-indexof-browser-alias
branch
from
2f5fb2e to
052d6db
Compare
ockham
added a commit
that referenced
this pull request
Mar 15, 2016
Don't use browser alias for component-each dependency
|
this broke component support |
|
Ugh, sorry about that. Apparently I'm somewhat ignorant about the actual component side of things -- what did I do wrong? (I tried to stick to the pattern of component/classes#27.) |
|
oh whoops. looks like that broke component support too haha basically the module name needs to match the repo name, as component loads modules from github (not from npm) |
|
Yikes. So the only way to do this is to |
This was referenced Mar 15, 2016
This was referenced Mar 31, 2016
|
Fix in #18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way,
component-csswon't break node code/tests when imported.