Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require debug ^2.6.9 #17

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Require debug ^2.6.9 #17

merged 2 commits into from
Apr 14, 2021

Conversation

nfriedly
Copy link
Contributor

@nfriedly nfriedly commented Oct 29, 2018

There is a minor security vulnerability in the module debug: https://nodesecurity.io/advisories/534

This was resolved in debug@2.6.9 and 3.1.0.

Debug introduced let/const in v3.2.0, breaking compatibility with node.js v4 and older browsers. This was reverted in 3.2.4, then re-released it in 4.0.0 - see debug-js/debug#603 for context around that.

In order avoid the vulnerability without loosing any compatibility, this change locks component-cookie to ^3.2.4 (>= 3.2.4 and < 4.0.0). (Update: now ^2.6.9)

This Fixes #16, relates to #15, and is is part of the fix for matthewmueller/next-cookies#7

@nfriedly nfriedly changed the title lock debug to v2.6.9 Require debug ^3.2.4 Oct 29, 2018
There is a minor security vulnerability in the module `debug`: https://nodesecurity.io/advisories/534

This was resolved in 2.6.9 and 3.1.0.

Debug introduced let/const in v3.2.0, breaking compatibility with node.js v4 and older browsers. This was reverted in 3.2.4, then re-released it in 4.0.0 - see debug-js/debug#603 for context around that.

In order avoid the vulnerability without loosing any compatibility, this change locks component-cookie to >= 3.2.4 < 4.0.0.

Version `^2.6.9` could alternatively be used if desired.

This Fixes component#16, Fixes component#15, and is is part of the fix for matthewmueller/next-cookies#7
based on feedback from @f2prateek
@nfriedly nfriedly changed the title Require debug ^3.2.4 Require debug ^2.6.9 Oct 29, 2018
@nfriedly nfriedly mentioned this pull request Oct 29, 2018
@jescalan
Copy link

This is pretty important to get merged and upgraded. This package currently exposes a security vulnerability. Is this package still maintained?

@jescalan
Copy link

cc @ucarion

@nfriedly
Copy link
Contributor Author

nfriedly commented Nov 26, 2018

BTW, I just locked next-cookies to component-cookie@1.1.3 - it works fine and doesn't have any vulnerabilities.

@Qix-
Copy link

Qix- commented Dec 19, 2018

debug@3 shows no vulnerabilities. Am I missing something?

@jescalan
Copy link

This package does not use debug@3 - https://github.com/component/cookie/blob/master/package.json#L7

@Qix-
Copy link

Qix- commented Dec 19, 2018

You should be able to upgrade safely, FWIW. The OP was written during one of the first upgrades in over a year, and the subsequent patch fixes.

@RajaBellebon
Copy link

Hello, what is the status on this PR? We are also facing some vulnerabilities issues bc of ms 0.7.1

Thank you

@nfriedly
Copy link
Contributor Author

This PR is still waiting on acceptance, as is my other bug fix, #19.

For next-cookies, I ended up switching to universal-cookie.

@Tenaria
Copy link

Tenaria commented Apr 6, 2021

Hi, is there any update on this? Similarly to the other comments, we are facing vulnerability issues with this as well and was wondering if there will be any movement on this soon 😄

@Tenaria
Copy link

Tenaria commented Apr 6, 2021

cc @ucarion 🥺

@ucarion
Copy link
Collaborator

ucarion commented Apr 14, 2021

Hi all -- it's been a few years since I've last published this package, but I am going to attempt to merge this PR and cut a new release.

@ucarion ucarion merged commit 5a2ee85 into component:master Apr 14, 2021
@ucarion
Copy link
Collaborator

ucarion commented Apr 14, 2021

I believe this PR is now released as part of v1.1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants