-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require debug ^2.6.9 #17
Conversation
There is a minor security vulnerability in the module `debug`: https://nodesecurity.io/advisories/534 This was resolved in 2.6.9 and 3.1.0. Debug introduced let/const in v3.2.0, breaking compatibility with node.js v4 and older browsers. This was reverted in 3.2.4, then re-released it in 4.0.0 - see debug-js/debug#603 for context around that. In order avoid the vulnerability without loosing any compatibility, this change locks component-cookie to >= 3.2.4 < 4.0.0. Version `^2.6.9` could alternatively be used if desired. This Fixes component#16, Fixes component#15, and is is part of the fix for matthewmueller/next-cookies#7
based on feedback from @f2prateek
This is pretty important to get merged and upgraded. This package currently exposes a security vulnerability. Is this package still maintained? |
cc @ucarion |
BTW, I just locked next-cookies to |
|
This package does not use |
You should be able to upgrade safely, FWIW. The OP was written during one of the first upgrades in over a year, and the subsequent patch fixes. |
Hello, what is the status on this PR? We are also facing some vulnerabilities issues bc of Thank you |
This PR is still waiting on acceptance, as is my other bug fix, #19. For next-cookies, I ended up switching to universal-cookie. |
Hi, is there any update on this? Similarly to the other comments, we are facing vulnerability issues with this as well and was wondering if there will be any movement on this soon 😄 |
cc @ucarion 🥺 |
Hi all -- it's been a few years since I've last published this package, but I am going to attempt to merge this PR and cut a new release. |
I believe this PR is now released as part of v1.1.5. |
There is a minor security vulnerability in the module
debug
: https://nodesecurity.io/advisories/534This was resolved in debug@2.6.9 and 3.1.0.
Debug introduced let/const in v3.2.0, breaking compatibility with node.js v4 and older browsers. This was reverted in 3.2.4, then re-released it in 4.0.0 - see debug-js/debug#603 for context around that.
In order avoid the vulnerability without loosing any compatibility, this change locks component-cookie to
(Update: now^3.2.4
(>= 3.2.4 and < 4.0.0).^2.6.9
)This Fixes #16, relates to #15, and is is part of the fix for matthewmueller/next-cookies#7