Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular Expression Denial of Service (component-cookie) #7

Closed
udanpe opened this issue Oct 27, 2018 · 5 comments
Closed

Regular Expression Denial of Service (component-cookie) #7

udanpe opened this issue Oct 27, 2018 · 5 comments

Comments

@udanpe
Copy link

udanpe commented Oct 27, 2018

component-cookie Locks debug to 2.2.0
what about use something else without bug?
screen shot 2018-10-28 at 02 37 26

@udanpe
Copy link
Author

udanpe commented Oct 28, 2018

@nfriedly unfortunately it's fix 1.1.4
component/cookie#15

nfriedly added a commit to nfriedly/cookie-1 that referenced this issue Oct 29, 2018
There is a minor security vulnerability in the module `debug`: https://nodesecurity.io/advisories/534

This was resolved in 2.6.9 and 3.1.0.

Debug introduced let/const in v3.2.0, breaking compatibility with node.js v4 and older browsers. This was reverted in 3.2.4, then re-released it in 4.0.0 - see debug-js/debug#603 for context around that.

In order avoid the vulnerability without loosing any compatibility, this change locks component-cookie to >= 3.2.4 < 4.0.0.

Version `^2.6.9` could alternatively be used if desired.

This Fixes component#16, Fixes component#15, and is is part of the fix for matthewmueller/next-cookies#7
nfriedly added a commit to nfriedly/cookie-1 that referenced this issue Oct 29, 2018
There is a minor security vulnerability in the module `debug`: https://nodesecurity.io/advisories/534

This was resolved in 2.6.9 and 3.1.0.

Debug introduced let/const in v3.2.0, breaking compatibility with node.js v4 and older browsers. This was reverted in 3.2.4, then re-released it in 4.0.0 - see debug-js/debug#603 for context around that.

In order avoid the vulnerability without loosing any compatibility, this change locks component-cookie to >= 3.2.4 < 4.0.0.

Version `^2.6.9` could alternatively be used if desired.

This Fixes component#16, Fixes component#15, and is is part of the fix for matthewmueller/next-cookies#7
@udanpe
Copy link
Author

udanpe commented Nov 10, 2018

what about return to version 1.1.3?

@nfriedly
Copy link
Collaborator

Yea, lets try that for now. Or else find an alternative...

@nfriedly
Copy link
Collaborator

I just published next-cookies v1.0.4 with component-cookie locked to v1.1.3.

@udanpe
Copy link
Author

udanpe commented Nov 11, 2018

@nfriedly component-cookie it's simple lib you can copy source code;)
https://github.com/component/cookie/blob/master/index.js

ucarion pushed a commit to component/cookie that referenced this issue Apr 14, 2021
* Require debug ^3.2.4

There is a minor security vulnerability in the module `debug`: https://nodesecurity.io/advisories/534

This was resolved in 2.6.9 and 3.1.0.

Debug introduced let/const in v3.2.0, breaking compatibility with node.js v4 and older browsers. This was reverted in 3.2.4, then re-released it in 4.0.0 - see debug-js/debug#603 for context around that.

In order avoid the vulnerability without loosing any compatibility, this change locks component-cookie to >= 3.2.4 < 4.0.0.

Version `^2.6.9` could alternatively be used if desired.

This Fixes #16, Fixes #15, and is is part of the fix for matthewmueller/next-cookies#7

* switch to ^2.6.9

based on feedback from @f2prateek
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants