-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MauticInstaller to allow plugins & themes #484
Conversation
…y names Update MauticInstaller to allow plugins & themes with custom directory names - Please do not merge yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update tests, please.
Tests added - please re-review. Thanks! |
https://github.com/composer/installers/pull/484/checks?check_run_id=2435477260 These checks is failing. Fix it, please. |
Fixed the failing tests, was only not able to reproduce the PHP 5.3 test locally but I think I fixed it due to PHP 7 array syntaxes. Tests still work and phpstan is now also happy |
Update MauticInstaller to allow plugins & themes with custom directory names - this has been verified (composer create-project mautic/recommended-project:4.x-dev mauticcomposerproject --no-interaction) and can be committed!
I know the suggestion is to use installer-name, but there was a composer library https://github.com/mautic/composer-plugin that already had the convention of install-directory-name so I wanted to keep compatibility with that.