Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC for the composerisation of Mautic TPROD-147 #9849

Conversation

nickveenhof
Copy link
Contributor

@nickveenhof nickveenhof commented Mar 28, 2021

Description:

This PR moves the plugins out of the codebase and allows Mautic to be installed with different ways. This PR ideally doesn't change the way people can install mautic, but it offers possibilities such as

composer create-project mautic/recommended-project:4.x-dev mauticcomposerproject --no-interaction

What is still open before this can get green light

  • the .htaccess files need to be added to vendor if it is installed from mautic/mautic instead of mautic/recommended-project. See also https://github.com/drupal/core-file-security/tree/9.2.x how it is done there.
  • The themes are still in the main repository, this is fine for now, but it is blocking for the users of the recommeded-project part. Ideally the themes live in app/themes and themes are also allowed in themes/ or wherever custom themes are placed. This is different than plugins as plugins are always optional, themes are not.
  • Many image files are not referenced correctly yet. The references still go to media/images, they should go to app/assets/images
  • Update MauticInstaller to allow plugins & themes composer/installers#484 should be committed, then we remove the complex override of this repository and the file gets a lot simpler.

Steps to test this PR:

  1. Load up this PR
  2. See if Mautic still works as expected
  3. Run composer update --with-dependencies, see if mautic still works as expecred

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Mar 28, 2021
@nickveenhof nickveenhof added assets Anything related to assets bc-break A BC break PR for major release milestones only builder-legacy Anything related to the legacy email or landing page builders dependencies Pull requests that update a dependency file essential This must be done to close the milestone feature A new feature for inclusion in minor or major releases mautic-4 Relates to Mautic 4.x php Pull requests that update Php code strategic-initiative labels Mar 29, 2021
@mautic mautic deleted a comment from codecov bot Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #9849 (61162df) into features (21cc28b) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 61162df differs from pull request most recent head 7819dd5. Consider uploading reports for the commit 7819dd5 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             features    #9849   +/-   ##
===========================================
  Coverage       39.66%   39.67%           
- Complexity      33978    33979    +1     
===========================================
  Files            1989     1989           
  Lines          105731   105732    +1     
===========================================
+ Hits            41943    41949    +6     
+ Misses          63788    63783    -5     
Impacted Files Coverage Δ Complexity Δ
...dles/InstallBundle/Configurator/Step/CheckStep.php 7.44% <0.00%> (ø) 47.00% <0.00%> (+1.00%)
...serBundle/Security/SAML/Store/CredentialsStore.php 100.00% <0.00%> (ø) 12.00% <0.00%> (ø%)
...es/CampaignBundle/Executioner/EventExecutioner.php 78.69% <0.00%> (+2.95%) 49.00% <0.00%> (ø%)

@dennisameling
Copy link
Member

@nickveenhof CS should be fixed now with 2c95643 - but we have a conflict due to a bunch of dependency updates from #9833. Would you mind having a look at that? Thanks! 🚀

@RCheesley RCheesley changed the title POC for the composerisation of Mautic POC for the composerisation of Mautic TPROD-147 Mar 29, 2021
@nickveenhof nickveenhof force-pushed the move-plugins-to-separate-repositories branch from 2c95643 to 7819dd5 Compare March 29, 2021 20:07
@RCheesley RCheesley added this to the 4.0-alpha milestone Mar 29, 2021
@RCheesley RCheesley removed this from the 4.0-alpha milestone Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Anything related to assets bc-break A BC break PR for major release milestones only builder-legacy Anything related to the legacy email or landing page builders cla-signed The PR contributors have signed the contributors agreement dependencies Pull requests that update a dependency file essential This must be done to close the milestone feature A new feature for inclusion in minor or major releases mautic-4 Relates to Mautic 4.x php Pull requests that update Php code strategic-initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants