PCHR-2395: Fix sick leave request #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkA84
suggested changes
Jul 13, 2017
igorpavlov-zz
force-pushed
the
PCHR-2395-fix-self-sick-leave-request
branch
from
929e5ee to
071d5e2
Compare
bmnepali
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When admin/manager record sick request for themselves, they are able to select checkboxes. This PR fixed this issue.
Before
After
Technical Details
To the
$ctrl.isRole('staff')condition was added$ctrl.isSelfRecordcondition introduced in #1999Comments
No tests required for this local change.