PCHR-2395: Fix admin self leave request popup

[igorpavlov-zz]

Overview

There are some issues with the Leave Request popup:

1. On My Leave page it looks and behaves the same as on Manager Leave or Admin Dashboard page.
2. The popup flickers during loading.
3. The popup allows admins/managers to choose themselves in the dropdown when recording on behalf.

This PR fixes these issues.

Before

After

Technical Details

Earlier in order to check if you record for yourself the system was checking if you are Staff. This is logically wrong, since Admin or Manager can also record for themselves via My Leave page, but they are not Staff.

1. A new flag was introduced: this.isSelfRecord. If this param is TRUE it indicates that you create/edit a request for yourself. For example:

<a
  leave-request-popup
  contact-id="vm.contactId"
  is-self-record="true">
</a>

2. Currently logged in admin is removed from the their managees list.

3. The flickering is fixed by adding an additional condition to HTML.

Comments

1. The Absence New Record dropdown now can also pass this.isSelfRecord through itself.

---

• Tests Pass

[reneolivo]

initTestController({
  contactId: leaveRequest.contact_id, // staff's contact id
  isSelfRecord: true,
  leaveRequest: leaveRequest
});

I see spec files have been amended to include the isSelfRecord: true option, but are there any note worthy test cases for isSelfRecord: false?

[reneolivo]

}.bind(this)); is being used above, it should be used here instead of var self = this, etc.

[igorpavlov-zz]

I see spec files have been amended to include the isSelfRecord: true option, but are there any note worthy test cases for isSelfRecord: false?

Any place in tests withdirectiveOptions that does not contain isSelfRecord tests what happens if isSelfRecord is false. And since isSelfRecord is a binding, it only can be true of false (even if not passed at all).

var directiveOptions = {
  contactId: adminID, // admin's ID
  ... // not specifying isSelfRecord tests if it is false
};

However, I added a test to make sure Admin does not appear in the list of managees.

[reneolivo]

if the statement is it loads exactly one contact shouldn't the test be something like expect($ctrl.managedContacts.length).toBe(1) or maybe the statement needs to change to something like it does not include admin on contact list ?

[igorpavlov-zz]

Done.