PCHR-4094: Add admin to leave request managees list #2811
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As per #1999 the admin was excluded from the list of managed contacts, admin was not able to create approved requests for themselves.
Now, admins are always treated as self leave approvers. This PR allows admins to select themselves from the managees list to create a leave request for themselves.
Before
Admin
admin@example.com
does not appear in the list:After
Admin
admin@example.com
appears in the list:Technical Details
Simply remove the existing code that checks if the user is admin and removes them from the list:
✅Manual Tests - passed
✅Jasmine Tests - amended and passed
✅JS distributive files - included
⏹CSS distributive files - not needed
⏹Backstop tests - not needed
⏹PHP Unit Tests - not needed