Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCHR-3997: Allow own leave approver #2785

Merged
merged 41 commits into from
Aug 2, 2018

Conversation

igorpavlov-zz
Copy link
Contributor

@igorpavlov-zz igorpavlov-zz commented Jul 23, 2018

Overview

This PR is for the "Allowing Own Leave Approver" epic. It contains the following PRs:

tunbola and others added 19 commits July 25, 2018 16:08
…when he is own leave approver or an Admin. Add tests. Remove un-used test.
…ns set in earlier tests, Fixed by setting permission to empty.
…n-actions

PCHR-4002: Allow User Who is Own Leave Approver Take Admin Actions on Own Requests
…-to-select-lr-status

PCHR-4019: Allow self leave approver to select leave request status on My Leave in the Leave Request Modal and delete a leave request
…r-delete

PCHR-4040: Allow user who is own Leave Approver to delete own requet
…-approver

PCHR-4045: Always treat admin as self leave approver
…vice. Add tests. Remove validation for absence type cancellation in Leave Request BAO.
@igorpavlov-zz igorpavlov-zz merged commit e6b3ae0 into staging Aug 2, 2018
@igorpavlov-zz igorpavlov-zz deleted the PCHR-3997-allow-own-leave-approver branch August 2, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants