PCHR-4019: Allow self leave approver to select leave request status on My Leave in the Leave Request Modal and delete a leave request

[igorpavlov-zz]

Overview

This PR allows self leave approver to select leave request status on My Leave in the Leave Request Modal and delete a leave request. In other words, they become "admins" on My Leave for their own leave requests if they are self leave approvers.

Before

After

Technical Details

Loading logged in contact instance instead of just their ID

Now we use the Contact.getLoggedIn that resolves with ContactInstance instead of calling Session.get to save some lines of code. We need ContactInstance to call ContactInstance.checkIfSelfLeaveApprover

// var loggedInContactId = '';
var loggedInContact;
// ...

loggedInContact.leaveManagees() // no need to do Contact.find(loggedInContactId) anymore
// ...

loggedInContact.checkIfSelfLeaveApprover() // same as above

Init role now checks if self leave approver

function initRole () {
  role = 'staff';

  return (vm.isSelfRecord
    ? initRoleBasedOnSelfLeaveApproverState()
    : initRoleBasedOnPermissions())

// ...

function initRoleBasedOnSelfLeaveApproverState () {
  return loggedInContact.checkIfSelfLeaveApprover()
    .then(function (isSelfLeaveApprover) {
      if (!isSelfLeaveApprover) {
        return;

      role = 'admin';
      vm.isSelfLeaveApprover = true;

// ....

function initCanManage () { // used in the init chain
  vm.canManage = vm.isRole('manager') || vm.isRole('admin');
}

Why role = 'admin'?

From the business logic perspective a self leave approver "administers" their own leave requests.

Why vm.isSelfLeaveApprover = true?

This is a new public property because we want to show some specific UI elements to the self leave approver: Status Selector and Delete button. We don't want to show other admin UI elements, such as, for example, the name of the contact on the top of the modal.

We also cannot only use vm.canManage property alone, because the templates also consider vm.isSelfRecord which prevents some UI elements to be shown when creating/editing you own leave request.

The solution is to use a combination in the templates:

&& !$ctrl.isSelfRecord
// becomes
&& (!$ctrl.isSelfRecord || $ctrl.isSelfLeaveApprover)

---

✅Manual Tests - passed
✅Jasmine Tests - amended and passed
✅JS distributive files - included
⏹CSS distributive files - not needed
⏹Backstop tests - not needed
⏹PHP Unit Tests - not needed

[reneolivo]

can we remove this from here, move it to a initCanManage function, and call that function from the init sequence after initRole?

[igorpavlov-zz]

Done. I also checked if we need finally, I don't think so, so I changed to then

[reneolivo]

since we now don't use Session, can you please remove any reference to it from this file?

[igorpavlov-zz]

Hm... I wonder why linter did not notice this.

[igorpavlov-zz]

Done.

[reneolivo]

The linter doesn't care if you don't use one of the parameters in your function. I guess it does that in case you need to use the third parameter, but not the second one.

[reneolivo]

you need to check if isSelfLeaveApprover is set to false in the basic tests group`.

[igorpavlov-zz]

Done.

[reneolivo]

Need to check if it's set to false as well.

[igorpavlov-zz]

Done.

[reneolivo]

*can