PCHR-4002: Allow User Who is Own Leave Approver Take Admin Actions on Own Requests

[tunbola]

Overview

Sequel to #2780, which allows a user to be assigned as own leave approver irrespective of the role of the user, This PR makes some changes in the way a user interacts with own requests especially when such a user is its own leave approver.
These changes allow a user irrespective of the role to assume the role of a leave manager on own request when the user is own leave approver. For example a Staff that is own leave approver can now cancel, approve and perform the same actions a leave manager can on a leave request for own request.
The new changes are summarised as follows

• An Admin can manage own requests irrespective of whether he is own leave approver or not
• A Staff can manage own request only if the staff is own leave approver
• A Manager can manage own request only if the manager is own leave approver

Before

• A user cannot manage own requests, i.e the user is treated as a staff when dealing with own request (even if staff is Admin or Manager) and as such cannot perform admin actions, such as approving the request and moving the request to statuses that is allowed for a manger.

After

• A user can now manage own requests when the user is own Leave approver, i.e the user can approve the request and move the request to statuses that a manager can move requests to.
  An Admin can manage own requests irrespective of whether he is own leave approver or not.

Technical Details

• Once a current user is the leave contact, the getStatusMatrixForCurrentUser of the leave request class would always return a Staff status transition matrix for the user even if the user is an Admin, this method is modified such that it returns the Manager status transition matrix for an Admin and for a user that is the leave contact and is own leave approver instead of returning the Staff status transition matrix.

  private function getStatusMatrixForCurrentUser($leaveRequestContactID) {
    $currentUserID = CRM_Core_Session::getLoggedInContactID();
    $statusMatrix = [];

    if ($this->shouldUseManagerMatrixForCurrentUser($leaveRequestContactID)) {
      $statusMatrix = $this->getManagerStatusMatrix();
    } elseif ($currentUserID == $leaveRequestContactID) {
      $statusMatrix = $this->getStaffStatusMatrix();
    }

    return $statusMatrix;
  }

[mickadoo]

I think there might be a typo in

A Manager can manage own request only of the manager is own leave approver

[mickadoo]

2 small things

[mickadoo]

Why was this added to tests in this PR?

[tunbola]

Some previous tests that ran set the permissions to that of an Admin. Also the same contact logged in is the leave contact for the test, so the test was assuming that the contact is an Admin that is trying to take actions on own request and an Admin cannot create a leave request with Awaiting approval status (status 3) based on the Manager status transition matrix. I simply set the permission to null which is what is needed when running the test for a staff for the purpose of this test.

[mickadoo]

A few lines like this are pretty long, do you think you could split the arguments onto separate lines?

[mickadoo]

looks good 🐧